Skip to content

test(kernel range reader): Adding integration tests for verifying reads and writes size#4894

Merged
abhishek10004 merged 6 commits into
v3.11.1_releasefrom
abhishek/3.11.1_local
Jul 17, 2026
Merged

test(kernel range reader): Adding integration tests for verifying reads and writes size#4894
abhishek10004 merged 6 commits into
v3.11.1_releasefrom
abhishek/3.11.1_local

Conversation

@abhishek10004

Copy link
Copy Markdown
Collaborator

Description

Adding integration tests for verifying reads and writes size

Link to the issue in case of a bug fix.

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@abhishek10004 abhishek10004 added the execute-integration-tests Run only integration tests label Jul 16, 2026
@abhishek10004
abhishek10004 requested review from a team and meet2mky as code owners July 16, 2026 18:39
@abhishek10004
abhishek10004 requested review from geertj and removed request for a team July 16, 2026 18:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new integration tests to verify large file read and write operations under specific FUSE max request size configurations. It also refactors the MiB constant into a shared utility package. The review feedback identified a potential flakiness issue in the write test due to memory alignment requirements when using syscall.O_DIRECT and suggested replacing magic numbers with constants to improve maintainability.

Comment thread tools/integration_tests/write_large_files/max_request_size_test.go
Comment thread tools/integration_tests/flag_optimizations/max_request_size_read_test.go Outdated
Comment thread tools/integration_tests/write_large_files/max_request_size_test.go Outdated
Comment thread tools/integration_tests/test_config.yaml
PranjalC100
PranjalC100 previously approved these changes Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v3.11.1_release@11820d3). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             v3.11.1_release    #4894   +/-   ##
==================================================
  Coverage                   ?   83.83%           
==================================================
  Files                      ?      173           
  Lines                      ?    21046           
  Branches                   ?        0           
==================================================
  Hits                       ?    17643           
  Misses                     ?     2747           
  Partials                   ?      656           
Flag Coverage Δ
unittests 83.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abhishek10004
abhishek10004 merged commit 547c9b2 into v3.11.1_release Jul 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants