refactor: remove not worked metasrv option#217
Open
MichaelScofield wants to merge 1 commit into
Open
Conversation
MichaelScofield
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes the non-functional --use-memory-store option from metasrv, including all related code, configuration, and CLI flags.
- Removed the
useMemoryMetaparameter and associated logic from metasrv component - Made Etcd configuration optional by removing the required validation tag
- Replaced the
useMemoryMetaboolean check with a nil check on the Etcd configuration - Removed the
--use-memory-metaCLI flag from cluster create command
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/config/baremetal.go | Removed validate:"required" tag from Etcd field to make it optional |
| pkg/components/metasrv.go | Removed useMemoryMeta parameter from NewMetaSrv and eliminated logic that generated --use-memory-store argument |
| pkg/cluster/baremetal/cluster.go | Removed useMemoryMeta field from Cluster struct, deleted WithMetastore option function, and updated NewClusterComponents signature |
| pkg/cluster/baremetal/create.go | Changed conditional from !c.useMemoryMeta to c.config.Etcd != nil to determine whether to create Etcd cluster |
| cmd/gtctl/cluster_create.go | Removed UseMemoryMeta field and --use-memory-meta CLI flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MichaelScofield
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #217 +/- ##
============================================
- Coverage 37.65% 20.93% -16.72%
============================================
Files 16 35 +19
Lines 1304 1949 +645
============================================
- Hits 491 408 -83
- Misses 708 1434 +726
- Partials 105 107 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2. fix golangci-lint 3. upgrade go version 4. use bare metal in e2e test
MichaelScofield
force-pushed
the
remove-not-worked-metasrv-option
branch
from
ff4233f to
172f08b
Compare
|
|
||
| func MustClose(c io.Closer) { | ||
| if err := c.Close(); err != nil { | ||
| _ = fmt.Errorf("failed to close: %v", err) |
Member
There was a problem hiding this comment.
What is the meaning of this place? If you want to print the error log, please refer to: https://github.com/GreptimeTeam/gtctl/blob/172f08b328724bdb132fb152dbd74e15dc71b2da/cmd/gtctl/cluster_create.go\#L207
|
|
||
| func RemoveAll(path string) { | ||
| if err := os.RemoveAll(path); err != nil { | ||
| _ = fmt.Errorf("failed to remove path %s: %v", path, err) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
--use-memory-storeis not worked in metasrv