Add sum to stats module#949
Open
psavery wants to merge 1 commit into
Open
Conversation
This generalizes the logic for average and sum to be in an `_accumulate` function which also takes the output type as a parameter. This allows `average()` output to remain as an `np.float32`, and the new `sum()` output can be a `np.float64` (since the results can be much larger). This also adds type annotations to existing functions, and some new tests. xref: HEXRD/hexrdgui#2030 Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
==========================================
+ Coverage 73.22% 73.26% +0.03%
==========================================
Files 146 146
Lines 22672 22711 +39
==========================================
+ Hits 16602 16639 +37
- Misses 6070 6072 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This generalizes the logic for average and sum to be in an
_accumulatefunction which also takes the output type as a parameter.This allows
average()output to remain as annp.float32, and the newsum()output can be anp.float64(since the results can be much larger).This also adds type annotations to existing functions, and some new tests.
xref: HEXRD/hexrdgui#2030
Affected Workflows
All