Skip to content

Refactor edm4hep JSON loader#821

Open
apausa wants to merge 31 commits intoHSF:mainfrom
apausa:check-process
Open

Refactor edm4hep JSON loader#821
apausa wants to merge 31 commits intoHSF:mainfrom
apausa:check-process

Conversation

@apausa
Copy link
Copy Markdown

@apausa apausa commented Mar 12, 2026

  • Refactor EDM4HEP JSON loader
  • Add type support for every schema
  • Integrate all schema types in edm4hep.ts

@apausa apausa closed this Mar 12, 2026
@apausa apausa reopened this Mar 16, 2026
@apausa apausa changed the title Refactor edm4hep JSON loader [WIP] Refactor edm4hep JSON loader Mar 16, 2026
@apausa apausa closed this Mar 16, 2026
@apausa apausa reopened this Mar 16, 2026
@EdwardMoyse
Copy link
Copy Markdown
Collaborator

EdwardMoyse commented Mar 26, 2026

Hey @apausa - not sure if you saw that the CI was failing? You can test this locally with yarn test:ci as described here: https://github.com/HSF/phoenix/blob/main/guides/developers/test-setup.md#running-the-tests-locally

@EdwardMoyse
Copy link
Copy Markdown
Collaborator

Ping @apausa

@apausa
Copy link
Copy Markdown
Author

apausa commented Apr 10, 2026

Hi @EdwardMoyse, I apologize for my late response, as my notifications were incorrectly configured. I hope to resolve this today. Thank you very much.

@apausa
Copy link
Copy Markdown
Author

apausa commented Apr 10, 2026

Hi @EdwardMoyse, the tests pass on my machine... They do fail when projects/phoenix-ui-components/dist is present, as both projects/phoenix-ui-components/package.json and projects/phoenix-ui-components/dist/package.json share the same name, which Jests finds conflicting :)

@apausa apausa changed the title [WIP] Refactor edm4hep JSON loader Refactor edm4hep JSON loader Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants