feat(effects-manager): add EffectsState enum for typed visual state management#887
Open
deveshbervar wants to merge 2 commits intoHSF:mainfrom
Open
feat(effects-manager): add EffectsState enum for typed visual state management#887deveshbervar wants to merge 2 commits intoHSF:mainfrom
deveshbervar wants to merge 2 commits intoHSF:mainfrom
Conversation
Collaborator
|
I would avoid reformating the comments unrelated to this PR, that makes much less clear what was actually changed. Besides that, I would not merge a PR adding an enum that is used nowhere. So I would wait for the first usage of it to introduce it. Sorry it I was not clear on that when I commented on #886 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
EffectsStateenum toEffectsManageras Phase 1 (part 1 of 4)of the refactoring proposed in #886.
What this adds
Why
The render path currently branches on implicit boolean checks
(
selectedObjectsSet.size > 0,hoverOutline !== null).Adding a new visual state — e.g.
DIMMEDfor pileup animation(#862) or
HIGHLIGHTEDfor masterclass mode — currently requiresfinding and updating every implicit branch manually.
This enum is the foundation for replacing those implicit checks
with typed state transitions in subsequent PRs.
Scope
This PR adds only the enum definition. No render path changes,
no shader changes, no behavior changes. All existing tests pass.
Part of #886 — Phase 1, part 1 of 4.