Migrated from GameInteractor Hooks to LUS Event System#6468
Open
KiritoDv wants to merge 32 commits into
Open
Conversation
leggettc18
reviewed
Apr 7, 2026
Contributor
leggettc18
left a comment
leggettc18
left a comment
There was a problem hiding this comment.
Haven't played or gone over everything yet but I've checked out the main core and have a few comments I'd like to get out there early on.
serprex
reviewed
Apr 7, 2026
Contributor
|
Decided to do some playtesting this morning, crashed right off the bat when I applied a preset The Preset in question: |
Contributor
|
On Windows, crashed right after o2r extraction completed |
… the main GI file
Malkierian
reviewed
May 30, 2026
Malkierian
reviewed
May 31, 2026
| ObjLightswitch* thisx = (ObjLightswitch*)actorPtr; | ||
| COND_ID_HOOK(ShouldActorUpdate, ACTOR_OBJ_LIGHTSWITCH, shouldRegister, [](IEvent* event) { | ||
| ShouldActorUpdate* ev = reinterpret_cast<ShouldActorUpdate*>(event); | ||
| ObjLightswitch* thisx = (ObjLightswitch*)ev->actor; |
Contributor
There was a problem hiding this comment.
Merely wanted to make a note here, it doesn't look like these ever get unregistered, so there's probably some hook bleed happening here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends On:
Build Artifacts