Skip to content

Add 2nd water control switch and sync floating key#6568

Open
f1ana wants to merge 1 commit into
HarbourMasters:developfrom
f1ana:hylia_switch_and_key_enhancements
Open

Add 2nd water control switch and sync floating key#6568
f1ana wants to merge 1 commit into
HarbourMasters:developfrom
f1ana:hylia_switch_and_key_enhancements

Conversation

@f1ana
Copy link
Copy Markdown
Contributor

@f1ana f1ana commented Apr 26, 2026

  • Separated out water control functionality from spot06
  • Added a 2nd switch (outside fishing against wall) to prevent being stranded. A separate hook makes sure that their pressed states sync up if one is pressed.
  • Water level now persists across scenes
  • Floating water key now follows the water level when changed (would stay fixed in place before)

Tried to follow existing patterns here, definitely open to feedback if I did not take the right approach.

Build Artifacts

@serprex
Copy link
Copy Markdown
Member

serprex commented May 31, 2026

please target develop, planning to merge develop-ackbar to develop without a 9.2.4 release & just release 9.3.0 after merging fixes & #5659

@f1ana f1ana force-pushed the hylia_switch_and_key_enhancements branch from 2b876d4 to 4da161f Compare June 1, 2026 00:42
@f1ana f1ana changed the base branch from develop-ackbar to develop June 1, 2026 00:43
@f1ana
Copy link
Copy Markdown
Contributor Author

f1ana commented Jun 1, 2026

please target develop, planning to merge develop-ackbar to develop without a 9.2.4 release & just release 9.3.0 after merging fixes & #5659

All set!

@f1ana f1ana force-pushed the hylia_switch_and_key_enhancements branch from 4da161f to 9388151 Compare June 1, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants