fix(ci): discover VC++ Redist via vswhere, not a hardcoded VS year - #9
Merged
Conversation
The first release run failed at CRT staging: the runner's Visual Studio lives under \18\ (VS 18), not the hardcoded \2022\ roots, so the scan found nothing. Discovery is now vswhere-first (shipped with every VS install and every GitHub runner image) with a version-agnostic directory glob fallback, and the error names every root it searched. Verified locally against a VS 18 Community install: CRT staged from 18\Community\VC\Redist\MSVC\14.44.35112, full installer built. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First release run failed at CRT staging: the runner's VS lives under `\18\ roots. Discovery is now vswhere-first with a version-agnostic glob fallback; the error names every searched root. Verified locally against VS 18 Community — CRT staged, full 0.2.1 installer built.
🤖 Generated with Claude Code