Extended docs regarding ValueAtQuantile() and added ValuesAreEquivalent()#39
Merged
Conversation
ahothan
reviewed
Oct 28, 2020
ahothan
reviewed
Nov 22, 2020
ahothan
left a comment
ahothan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but could you please take care of removing the panic as commented.
…|| numberOfSignificantValueDigits > 5. Adding linter check to CI
Collaborator
Author
@ahothan changes per the PR review are in :) |
ahothan
approved these changes
Nov 24, 2020
…erOfSignificantValueDigits limits ).
Collaborator
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ValuesAreEquivalent() method and extendes the ValueAtQuantile() docs so that it's clear that it returns the largest value that (100% - percentile) of the overall recorded value entries in the histogram are either larger than or equivalent to.
It can be used as further reference for issue #23 and why it happens.
wdyt @ahothan @giltene ?