fix: preserve literal dollar signs in config values - #120
Open
AruneshDwivedi wants to merge 1 commit into
Open
Conversation
readFileAndExpandEnv used os.ExpandEnv which strips bare $ characters
from values such as passwords, corrupting them. Expand only the ${VAR}
form so intentional environment substitution still works while literal
dollar signs are preserved.
Fixes HeavyHorst#88
Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readFileAndExpandEnv used os.ExpandEnv, which expands every bare $ in a config file. That corrupts literal dollar signs inside values such as a redis password (uhQhu4watyTgn$Q$ became uhQhu4watyTgn$), breaking connections. The change expands only the ${VAR} form, so intentional environment substitution still works while literal dollar signs are preserved. Added a regression test over readFileAndExpandEnv covering both forms.