Skip to content

fix: normalize clip.effects to prevent crash on missing params #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: normalize clip.effects to prevent crash on missing params #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/state/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,16 @@ export function sanitizeProject(p: Project): Project {
if (!Number.isFinite(c.speed) || c.speed <= 0) c.speed = 1
c.transform = { ...newClipDefaults().transform, ...(c.transform ?? {}) }
c.gain = anim(c.gain, 1)
c.effects ??= []
// same invariant updateClip enforces on a live patch: a hand-edited or
// foreign project file can carry an effect with no params, and every
// reader (BlurControls, GlowControls, …) reads fx.params directly
c.effects = (c.effects ?? [])
.filter((e) => e && typeof e.id === 'string' && typeof e.type === 'string')
.map((e) => ({
...e,
enabled: typeof e.enabled === 'boolean' ? e.enabled : true,
params: e.params && typeof e.params === 'object' ? e.params : {}
}))
forEachAnim(c, (a) => anim(a, Number.isFinite((a as Anim)?.value) ? (a as Anim).value : 0))
}
}
Expand Down Expand Up @@ -1178,7 +1187,22 @@ export const useEditor = create<EditorState>((set, get) => ({
set((s) => {
const p = clone(s.project)
const f = findClip(p, clipId)
if (f) Object.assign(f.clip, patch)
if (f) {
Object.assign(f.clip, patch)
// a patch built outside the effects UI (kadr_eval, foreign project
// data) can hand an effect with no params — every reader downstream
// (BlurControls, GlowControls, and any future consumer) assumes the
// Effect shape and reads fx.params directly, so an id/type-less or
// params-less entry here becomes an uncaught render crash the moment
// the clip is selected, not a contained failure
f.clip.effects = (f.clip.effects ?? [])
.filter((e) => e && typeof e.id === 'string' && typeof e.type === 'string')
.map((e) => ({
...e,
enabled: typeof e.enabled === 'boolean' ? e.enabled : true,
params: e.params && typeof e.params === 'object' ? e.params : {}
}))
}
return { project: p }
}),

Expand Down