Make SA_SPELLBREAKER's HP siphon deal visible, non-lethal damage - #3428
Open
MrKeiKun wants to merge 2 commits into
Open
Make SA_SPELLBREAKER's HP siphon deal visible, non-lethal damage#3428MrKeiKun wants to merge 2 commits into
MrKeiKun wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
In official Aegis,
SA_SPELLBREAKERdeals visible damage to the target as part of its HP siphon effect (recovering 2% max HP for the caster at skill level 5+, on PvP maps against players). Hercules currently applies this viastatus_zap(), which reduces the target's HP silently with noclif->damagepacket, so the target sees no hit or damage number.SP drain from the skill is unaffected and remains silent.
Issues addressed: #880