Add MD_NOCAST_SKILL mob mode to disable mob_skill_db skill usage - #3447
Open
MrKeiKun wants to merge 1 commit into
Open
Add MD_NOCAST_SKILL mob mode to disable mob_skill_db skill usage#3447MrKeiKun wants to merge 1 commit into
MrKeiKun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This adds a new mode flag,
MD_NOCAST_SKILL(0x00020000), that is checked at the top ofmob_use_skill()and short-circuits all skill usage (idle and combat states alike) when set. It's exposed:mob_db.confModekey (NoCastSkill: true/false), for permanently disabling skill use on specific monsters/spawnssetunitdata/getunitdata(UDT_MODE, ...), matching the workaround the reporter was already trying to useAlso corrected the doc note on
MD_CANATTACKindoc/mob_db_mode_list.md, which claimed "skills are always allowed" — that's no longer unconditionally true.Issues addressed: #1770