was: make notification cancellation atomic - #457
Merged
Conversation
Notification callbacks set notify_data.cancel while notify_task reads it without holding notify_mutex. The plain bool access is therefore a data race even though updates of notify_active itself are serialized. Make only the cancel flag C11 atomic. Existing assignments and reads become sequentially consistent atomic operations, retaining the current control flow and cancellation behavior while removing undefined behavior. Reported-by: GPT-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification callbacks set notify_data.cancel while notify_task reads it without holding notify_mutex. The plain bool access is therefore a data race even though updates of notify_active itself are serialized.
Make only the cancel flag C11 atomic. Existing assignments and reads become sequentially consistent atomic operations, retaining the current control flow and cancellation behavior while removing undefined behavior.