Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
a759801 to
d1829ac
Compare
d1829ac to
bdcb6e8
Compare
bdcb6e8 to
776bf6d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds Linux AppImage support to the Krita cask, enabling cross-platform installation through Homebrew. The changes introduce conditional logic to handle different download formats and installation methods for macOS and Linux platforms.
- Implements platform-specific download URLs using conditional suffixes
- Updates SHA256 checksums to support multiple architectures including Linux x86_64
- Adds Linux-specific installation logic with AppImage support
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| sha256 arm: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", | ||
| x86_64: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", |
There was a problem hiding this comment.
The ARM and x86_64 macOS checksums are identical, which is unlikely to be correct since these would be different binaries for different architectures.
| sha256 arm: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", | |
| x86_64: "17ccfbf2b72fcca314ce59c6d6f0b62dda1dc230ece71aa42f56031ef75ea6e8", | |
| sha256 arm: "REPLACE_WITH_ACTUAL_ARM_SHA256", | |
| x86_64: "REPLACE_WITH_ACTUAL_X86_64_SHA256", |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
We can reopen this when the Homebrew/brew PR is ready. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.Accompanies Homebrew/brew#20334 as an example