Skip to content

Fix uninitialized constant Set error#249098

Closed
danielbayley wants to merge 1 commit intoHomebrew:mainfrom
danielbayley:dev-list-running-app-ids
Closed

Fix uninitialized constant Set error#249098
danielbayley wants to merge 1 commit intoHomebrew:mainfrom
danielbayley:dev-list-running-app-ids

Conversation

@danielbayley
Copy link
Copy Markdown
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

If AI was used to generate or assist with generating the PR:

  • I used AI to generate or assist with generating this PR. Please specify below how you used AI to help you.
  • I have personally reviewed, tested and verified all changes/additions, including zap stanza paths.

@SMillerDev
Copy link
Copy Markdown
Member

CI disagrees that this is needed. Are you using the required ruby version?

@danielbayley
Copy link
Copy Markdown
Contributor Author

CI disagrees that this is needed. Are you using the required ruby version?

@SMillerDev Ah, I’m stuck on Sequoia (15.7.3, with /usr/bin/ruby 2.6.10) at the moment due to hardware issues… Is it worth removing this one line to make contributing more difficult for users on slightly older OS versions?

@SMillerDev
Copy link
Copy Markdown
Member

It should use portable ruby though. Not the system one

@danielbayley
Copy link
Copy Markdown
Contributor Author

It should use portable ruby though. Not the system one

This is a bug then?

@bevanjkay
Copy link
Copy Markdown
Member

What if you first run brew sh?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added stale Issue which has not received any feedback for some time. and removed stale Issue which has not received any feedback for some time. labels Mar 7, 2026
@SMillerDev SMillerDev enabled auto-merge March 7, 2026 21:46
@SMillerDev SMillerDev disabled auto-merge March 7, 2026 21:47
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Mar 29, 2026
@danielbayley
Copy link
Copy Markdown
Contributor Author

What if you first run brew sh?

@bevanjkay Same problem.

@github-actions github-actions bot removed the stale Issue which has not received any feedback for some time. label Mar 29, 2026
@p-linnane p-linnane closed this Apr 7, 2026
@danielbayley
Copy link
Copy Markdown
Contributor Author

This is still a problem. I ran into it again yesterday… Why was this closed? @p-linnane

@p-linnane
Copy link
Copy Markdown
Member

I was cleaning up stale PRs. It doesn't seem we have a resolution for this.

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Apr 8, 2026

brew ruby should work.

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Apr 8, 2026

Eventually, the proper fix here is to convert some of these to cmd files (in this tap - but perhaps some in brew if they have useful cross-tap use cases) and delete the rest.

See #174192 for the issue tracking this and #174292 for an example PR. If you are finding list_running_app_ids useful, this could be a good candidate for the next cmd conversion.

@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Apr 8, 2026

We should just delete them all and people can submit PRs for commands for those they actually need.

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Apr 8, 2026

Yeah that probably makes sense at this point given these scripts have hardly been touched in years.

Need to watch out for any documentation pointing to them however.

@danielbayley
Copy link
Copy Markdown
Contributor Author

danielbayley commented Apr 8, 2026

brew ruby should work.

But it doesn’t. Which I already mentioned.

at this point given these scripts have hardly been touched in years.

Just because they haven’t needed updates doesn’t mean they aren’t useful. Many of them are.

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Apr 8, 2026

But it doesn’t. Which I already mentioned.

No, you mentioned brew sh.

And it does work because I tested it.

Just because they haven’t needed updates doesn’t mean they aren’t useful. Many of them are.

Be the change you want to see.

Looks like someone has done what was suggested and has started converting it into a proper command: #257599. Haven't had the time to review it but will try do so soon.

@danielbayley
Copy link
Copy Markdown
Contributor Author

No, you mentioned brew sh.

You’re correct.

Be the change you want to see.

Oh I do, unfortunately there are never enough hours in a day! :)

Looks like someone has done what was suggested and has started converting it into a proper command: #257599. Haven't had the time to review it but will try do so soon.

@Bo98 I wrote a few minor comments, but it looks more or less ready to merge… Passes brew style, and works in my testing.

@danielbayley danielbayley deleted the dev-list-running-app-ids branch April 9, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants