Add cross-origin headers required for SABs#563
Open
netpro2k wants to merge 1 commit into
Open
Conversation
|
Related PR on the client side Hubs-Foundation/hubs#4555 |
brianpeiris
suggested changes
Apr 26, 2022
brianpeiris
left a comment
brianpeiris
left a comment
Contributor
There was a problem hiding this comment.
I think there was a critical typo here.
| plug(:put_secure_browser_headers) | ||
| plug(:put_secure_browser_headers, %{ | ||
| "cross-origin-opener-policy" => "same-origin", | ||
| "cross-origin-resource-policy" => "require-corp" |
Contributor
There was a problem hiding this comment.
Pretty sure this is wrong, and you actually meant to use the embedder-policy header, not the resource-policy header.
Suggested change
| "cross-origin-resource-policy" => "require-corp" | |
| "cross-origin-embedder-policy" => "require-corp" |
| plug(:put_secure_browser_headers) | ||
| plug(:put_secure_browser_headers, %{ | ||
| "cross-origin-opener-policy" => "same-origin", | ||
| "cross-origin-resource-policy" => "require-corp" |
Contributor
There was a problem hiding this comment.
Suggested change
| "cross-origin-resource-policy" => "require-corp" | |
| "cross-origin-embedder-policy" => "require-corp" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the required headers to load Hubs in a secure context to access SharedArrayBuffers and high resolution timers. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer#security_requirements. This also increases security in general, but will make it more difficult to communicate with iframed hubs clients if that becomes necessary in the future.
Reticulum compliment to Hubs-Foundation/hubs#4252