Conversation
* feat: add wayle bar support as alternative to waybar - Add wayle to session.py known bars for clean session management - Add wallbash hook (wayle.dcol) to sync wallpaper colors with wayle - Make waybar.dcol conditional: skip waybar update when not running * dev * docs: add @0xGeN02 to contributors * feat: add wayle-bin and matugen-bin as optional packages in pkg_extra.lst * feat: add wallbash-to-wayle palette bridge for dynamic theming Uses dcol_* environment variables passed by wallbash's fn_wallbash to set wayle palette colors on every wallpaper/theme change. Files placed in .config/hyde/wallbash/ (non-core component). * fix: hyde-shell pypr subcommand passes args as single string to pypr CLI (#1741) When running `hyde-shell pypr toggle console`, the `run_pypr()` function used `${*:-help}` to capture arguments into a scalar variable. When passed to `pypr "${message[@]}"`, the scalar expands as a single string "toggle console" instead of two separate args. The pypr client then normalizes spaces to underscores, looking up "toggle_console" instead of the "toggle" command with "console" as its argument. Additionally, socket direct writes via nc/socat/ncat lacked a trailing newline, which the pyprland daemon's readline() expects. Fix by using a bash array (`local -a msg=("$@")`) to preserve proper word-splitting, and adding `\n` to socket writes. # Pull Request ## Description Please read these instructions and remove unnecessary text. - Try to include a summary of the changes and which issue is fixed. - Also include relevant motivation and context (if applicable). - Make sure to make PR against dev and not the master - List any dependencies that are required for this change. (e.g., packages or other PRs) - Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue) - Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable) ## Type of change Please put an `x` in the boxes that apply: - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [ ] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [ ] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Screenshots (if appropriate) ## Additional context Add any other context about the problem here. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Enhanced socket message handling for more reliable and consistent command argument processing across all operations. * Improved default command behavior to automatically display helpful information when commands are executed without any arguments provided. * Optimized internal message formatting and delivery while maintaining complete compatibility with existing fallback communication mechanisms for continued system reliability and operational stability. [](https://app.coderabbit.ai/change-stack/HyDE-Project/HyDE/pull/1741) <!-- end of auto-generated comment: release notes by coderabbit.ai --> * Remove * fix: Fix Hyprland 0.55 breaking changes in configuration files (#1742) * fix(hypr): unset HL_INITIAL_WORKSPACE_TOKEN in startup to prevent apps locking to workspace 1 (#1781) * docs: sync Chinese README with English version (#1779) * fix(volume): use [[ ]] for VOLUME_PIPEWIRE_ENABLE comparison (#1786) The PipeWire detection fallback was written as `|| $VOLUME_PIPEWIRE_ENABLE == true`, which executes the variable's value as a command with `==` and `true` as arguments instead of comparing it. On PulseAudio-only systems (where the pactl grep does not short-circuit) every invocation printed "==: command not found" when the variable was unset, and setting it to "true" only worked by accident of running /usr/bin/true. Wrap the check in [[ ]] so it is an actual string comparison. Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Khing <53417443+kRHYME7@users.noreply.github.com> * fix(pm): restore module header position in zypper.py (#1784) count_updates and list_updates were inserted above the module docstring and the `from __future__ import annotations` line. Python requires __future__ imports at the top of the file, so the module raised SyntaxError on import, breaking `hyde-shell pm` on openSUSE. Move both functions to the end of the file, matching the layout of the other manager modules. Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Khing <53417443+kRHYME7@users.noreply.github.com> * Fix/globalcontrol wallpaper validation (#1785) * fix(lib): add missing $ to XDG_DATA_HOME fallback path in get_hyprConf The first fallback config path in get_hyprConf was the literal string "XDG_DATA_HOME/hyde/hyde.conf", which never exists, so user-level default theme values in $XDG_DATA_HOME/hyde/hyde.conf were silently skipped (the grep error is suppressed by 2>/dev/null). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(wallpaper): validate nonexistent path passed to --set The check used `[ -z "$wallpaper_path" ] && [ ! -f "$wallpaper_path" ]`, so a non-empty path to a missing file skipped validation entirely and failed later in get_hashmap with a confusing "No image found in any source" error. Use || so both empty and nonexistent paths report "Wallpaper not found" as intended. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Khing <53417443+kRHYME7@users.noreply.github.com> * fix(zsh,hyde-shell): prevent PATH duplication on repeated source (#1823) Co-authored-by: NoistNT <noistnt@users.noreply.github.com> * Lua (#1755) * lua * Added lua configs * Added lua support for Scripts * [for testing ] Added deez dots manifest files * [for testing ] Added deez dots manifest files * some migration logic for zsh * Added the partial deps list * Removed old hyprlang. * added defualt blnk hyprland.lua * Added hyprland error when wallbash for hyprland is not yet generated * Added hyprland error when wallbash for hyprland is not yet generated * Clean up all deprecated scripts * fixing session management logic for newer hyprland * reload on on common --reload and better keb hint UX and alt tab behavior * altab implementation and better binds handling * fix hyprlock * fix dolphin * fix dolphin * move kdeglobals to hyde bundle * cleanup * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * anim * fix batteerynotify dameon * resolves some issues * no anim on selection layer * exposes hyprland.anim.duration_scale for animation speed(duration) control * Silent fail when missing toml parser * fix altab * fix altab * y * app2unit wrapper for non systemd * kitty * some adjustments * added pm agnostic system update ui * cleanup * fix sys update * pm * fix: gobject theming * Fix waybar, move dconf to use lua lgi * make keepass and bitwarden float * some foundation for i18n , docs etc for scripts * todo * fix screenshot conflict * org * some handling on fresh install * almost * Update Configs/.local/bin/hyde-shell Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/luautils/selector/rofi.lua Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/keybinds_hint.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/session/compositor/hyprland.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/session/plugins/brave.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/shell/activate.fish Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix shell activations * uwsm hyprland env * fix session hyprland compositor * fix luau hyprtils rofi helper * fix no regex alternation on lua. * fix lua runtime * fix json output on lua * fix list builtin in completions --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: 0xGeN02 <manuelmateodgl02@gmail.com> Co-authored-by: kRHYME7 <53417443+kRHYME7@users.noreply.github.com> Co-authored-by: yun <chenzm39@gmail.com> Co-authored-by: PureFallen <68307987+PureFallen@users.noreply.github.com> Co-authored-by: BigDawnGhost <yelouis231589@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Ariel Piazzano <104594670+NoistNT@users.noreply.github.com> Co-authored-by: NoistNT <noistnt@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
](https://app.coderabbit.ai/change-stack/HyDE-Project/HyDE/pull/1741){kind=link}
* feat: add wayle bar support as alternative to waybar - Add wayle to session.py known bars for clean session management - Add wallbash hook (wayle.dcol) to sync wallpaper colors with wayle - Make waybar.dcol conditional: skip waybar update when not running * dev * docs: add @0xGeN02 to contributors * feat: add wayle-bin and matugen-bin as optional packages in pkg_extra.lst * feat: add wallbash-to-wayle palette bridge for dynamic theming Uses dcol_* environment variables passed by wallbash's fn_wallbash to set wayle palette colors on every wallpaper/theme change. Files placed in .config/hyde/wallbash/ (non-core component). * fix: hyde-shell pypr subcommand passes args as single string to pypr CLI (#1741) When running `hyde-shell pypr toggle console`, the `run_pypr()` function used `${*:-help}` to capture arguments into a scalar variable. When passed to `pypr "${message[@]}"`, the scalar expands as a single string "toggle console" instead of two separate args. The pypr client then normalizes spaces to underscores, looking up "toggle_console" instead of the "toggle" command with "console" as its argument. Additionally, socket direct writes via nc/socat/ncat lacked a trailing newline, which the pyprland daemon's readline() expects. Fix by using a bash array (`local -a msg=("$@")`) to preserve proper word-splitting, and adding `\n` to socket writes. # Pull Request ## Description Please read these instructions and remove unnecessary text. - Try to include a summary of the changes and which issue is fixed. - Also include relevant motivation and context (if applicable). - Make sure to make PR against dev and not the master - List any dependencies that are required for this change. (e.g., packages or other PRs) - Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue) - Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable) ## Type of change Please put an `x` in the boxes that apply: - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [ ] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [ ] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Screenshots (if appropriate) ## Additional context Add any other context about the problem here. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Enhanced socket message handling for more reliable and consistent command argument processing across all operations. * Improved default command behavior to automatically display helpful information when commands are executed without any arguments provided. * Optimized internal message formatting and delivery while maintaining complete compatibility with existing fallback communication mechanisms for continued system reliability and operational stability. [](https://app.coderabbit.ai/change-stack/HyDE-Project/HyDE/pull/1741) <!-- end of auto-generated comment: release notes by coderabbit.ai --> * Remove * fix: Fix Hyprland 0.55 breaking changes in configuration files (#1742) * fix(hypr): unset HL_INITIAL_WORKSPACE_TOKEN in startup to prevent apps locking to workspace 1 (#1781) * docs: sync Chinese README with English version (#1779) * fix(volume): use [[ ]] for VOLUME_PIPEWIRE_ENABLE comparison (#1786) The PipeWire detection fallback was written as `|| $VOLUME_PIPEWIRE_ENABLE == true`, which executes the variable's value as a command with `==` and `true` as arguments instead of comparing it. On PulseAudio-only systems (where the pactl grep does not short-circuit) every invocation printed "==: command not found" when the variable was unset, and setting it to "true" only worked by accident of running /usr/bin/true. Wrap the check in [[ ]] so it is an actual string comparison. Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Khing <53417443+kRHYME7@users.noreply.github.com> * fix(pm): restore module header position in zypper.py (#1784) count_updates and list_updates were inserted above the module docstring and the `from __future__ import annotations` line. Python requires __future__ imports at the top of the file, so the module raised SyntaxError on import, breaking `hyde-shell pm` on openSUSE. Move both functions to the end of the file, matching the layout of the other manager modules. Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Khing <53417443+kRHYME7@users.noreply.github.com> * Fix/globalcontrol wallpaper validation (#1785) * fix(lib): add missing $ to XDG_DATA_HOME fallback path in get_hyprConf The first fallback config path in get_hyprConf was the literal string "XDG_DATA_HOME/hyde/hyde.conf", which never exists, so user-level default theme values in $XDG_DATA_HOME/hyde/hyde.conf were silently skipped (the grep error is suppressed by 2>/dev/null). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(wallpaper): validate nonexistent path passed to --set The check used `[ -z "$wallpaper_path" ] && [ ! -f "$wallpaper_path" ]`, so a non-empty path to a missing file skipped validation entirely and failed later in get_hashmap with a confusing "No image found in any source" error. Use || so both empty and nonexistent paths report "Wallpaper not found" as intended. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Khing <53417443+kRHYME7@users.noreply.github.com> * fix(zsh,hyde-shell): prevent PATH duplication on repeated source (#1823) Co-authored-by: NoistNT <noistnt@users.noreply.github.com> * Lua (#1755) * lua * Added lua configs * Added lua support for Scripts * [for testing ] Added deez dots manifest files * [for testing ] Added deez dots manifest files * some migration logic for zsh * Added the partial deps list * Removed old hyprlang. * added defualt blnk hyprland.lua * Added hyprland error when wallbash for hyprland is not yet generated * Added hyprland error when wallbash for hyprland is not yet generated * Clean up all deprecated scripts * fixing session management logic for newer hyprland * reload on on common --reload and better keb hint UX and alt tab behavior * altab implementation and better binds handling * fix hyprlock * fix dolphin * fix dolphin * move kdeglobals to hyde bundle * cleanup * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * anim * fix batteerynotify dameon * resolves some issues * no anim on selection layer * exposes hyprland.anim.duration_scale for animation speed(duration) control * Silent fail when missing toml parser * fix altab * fix altab * y * app2unit wrapper for non systemd * kitty * some adjustments * added pm agnostic system update ui * cleanup * fix sys update * pm * fix: gobject theming * Fix waybar, move dconf to use lua lgi * make keepass and bitwarden float * some foundation for i18n , docs etc for scripts * todo * fix screenshot conflict * org * some handling on fresh install * almost * Update Configs/.local/bin/hyde-shell Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/luautils/selector/rofi.lua Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/keybinds_hint.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/session/compositor/hyprland.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/session/plugins/brave.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/shell/activate.fish Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix shell activations * uwsm hyprland env * fix session hyprland compositor * fix luau hyprtils rofi helper * fix no regex alternation on lua. * fix lua runtime * fix json output on lua * fix list builtin in completions --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Lua (#1835) * lua * Added lua configs * Added lua support for Scripts * [for testing ] Added deez dots manifest files * [for testing ] Added deez dots manifest files * some migration logic for zsh * Added the partial deps list * Removed old hyprlang. * added defualt blnk hyprland.lua * Added hyprland error when wallbash for hyprland is not yet generated * Added hyprland error when wallbash for hyprland is not yet generated * Clean up all deprecated scripts * fixing session management logic for newer hyprland * reload on on common --reload and better keb hint UX and alt tab behavior * altab implementation and better binds handling * fix hyprlock * fix dolphin * fix dolphin * move kdeglobals to hyde bundle * cleanup * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * anim * fix batteerynotify dameon * resolves some issues * no anim on selection layer * exposes hyprland.anim.duration_scale for animation speed(duration) control * Silent fail when missing toml parser * fix altab * fix altab * y * app2unit wrapper for non systemd * kitty * some adjustments * added pm agnostic system update ui * cleanup * fix sys update * pm * fix: gobject theming * Fix waybar, move dconf to use lua lgi * make keepass and bitwarden float * some foundation for i18n , docs etc for scripts * todo * fix screenshot conflict * org * some handling on fresh install * almost * Update Configs/.local/bin/hyde-shell Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/luautils/selector/rofi.lua Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/keybinds_hint.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/session/compositor/hyprland.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/session/plugins/brave.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Configs/.local/lib/hyde/shell/activate.fish Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix shell activations * uwsm hyprland env * fix session hyprland compositor * fix luau hyprtils rofi helper * fix no regex alternation on lua. * fix lua runtime * fix json output on lua * fix list builtin in completions * safe theme lua state generation --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: 0xGeN02 <manuelmateodgl02@gmail.com> Co-authored-by: kRHYME7 <53417443+kRHYME7@users.noreply.github.com> Co-authored-by: yun <chenzm39@gmail.com> Co-authored-by: PureFallen <68307987+PureFallen@users.noreply.github.com> Co-authored-by: BigDawnGhost <yelouis231589@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Ariel Piazzano <104594670+NoistNT@users.noreply.github.com> Co-authored-by: NoistNT <noistnt@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…lves merge conflict)
fix [Lua | Bug]: `lua_state.colors` is absent Fixes #1840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated PR to promote changes from
rctomaster.Please review and test before merging.
See TESTING.md for complete testing instructions.
According to our release policy, this PR is expected to be merged on: 1st or 3rd Friday of the month
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the project.
lua_state.colorsis absent Fixes [Lua | Bug]:lua_state.colorsis absent #1840 (a8ef508) by kRHYME7Please review the changes carefully before merging.