Skip to content

#1869 feat: add wezterm configuration and wallbash theming - #1874

Open
RAprogramm wants to merge 7 commits into
HyDE-Project:devfrom
RAprogramm:1869
Open

#1869 feat: add wezterm configuration and wallbash theming#1874
RAprogramm wants to merge 7 commits into
HyDE-Project:devfrom
RAprogramm:1869

Conversation

@RAprogramm

@RAprogramm RAprogramm commented Jul 29, 2026

Copy link
Copy Markdown

Closes #1869

WezTerm gets what kitty already has: HyDE defaults, wallbash colours, a metafile, and registration as a session terminal.

Path Action
Configs/.config/wezterm/hyde.lua sync, HyDE defaults behind require("hyde").config()
Configs/.config/wezterm/wezterm.lua preserve, the user's entry point
Configs/.local/share/wallbash/theme/wezterm.dcol the palette, rendered to ~/.config/wezterm/hyde.toml
Scripts/dots/wezterm.toml dependency and deployment
Scripts/dots-groups/optionals.toml, Configs/.config/xdg-terminals.list one line each

Colours use WezTerm's native scheme mechanism, taken from the template in terminal-emulators: wallbash writes a scheme named wallbash, and add_to_config_reload_watch_list makes a theme switch reload WezTerm on its own. No apply hook needed.

The scheme is selected only once the file exists, because naming a missing scheme makes WezTerm log an error on every start — which is what a fresh install looks like before the first theme switch.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Testing

wezterm --config-file … show-keys against WezTerm 20260117: clean with the palette present and with it absent. Template renders to valid TOML, scheme name and 8 ansi colours checked. sh tests/run.sh passes.

Summary by CodeRabbit

  • New Features

    • Added optional WezTerm support, including configuration synchronization and wallbash theming.
    • WezTerm can now be selected as a session terminal.
    • WezTerm is recognized among supported terminal applications.
  • Documentation

    • Updated the changelog with details about optional WezTerm support.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds optional WezTerm package and dotfile synchronization metadata, registers WezTerm as a terminal, and documents its configuration and Wallbash theming support.

Changes

WezTerm integration

Layer / File(s) Summary
WezTerm installation and registration
Scripts/dots/wezterm.toml, Scripts/dots-groups/optionals.toml, Configs/.config/xdg-terminals.list, CHANGELOG.md
Adds package mappings and dotfile rules, includes WezTerm in optional configurations, registers its desktop entry, and documents the available configuration and theming support.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit hops through config land,
WezTerm files now neatly stand.
Wallbash colors softly glow,
Optional paths know where to go.
“A tidy terminal!” says the doe.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: adding WezTerm configuration and wallbash theming.
Linked Issues check ✅ Passed The PR adds WezTerm registration and optional install metadata, matching the linked feature's integration goals.
Out of Scope Changes check ✅ Passed Changes are limited to WezTerm setup metadata, terminal registration, and a changelog note.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RAprogramm RAprogramm added the enhancement New feature or request label Jul 29, 2026
@RAprogramm

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kRHYME7

kRHYME7 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@RAprogramm

https://github.com/HyDE-Project/terminal-emulators/ maybe we can host it here and use the deez's dots.toml in the root dir for wezterm installation ? Also we can mirror the installer here in hyde if you want to include it in dots/extra.toml. But for now I think deez-dots does not support mulitple git url but it supports sources like

source = blob+https://github.com/HyDE-Project/terminal-emulators/archive/refs/heads/main.zip and you can navigate the configs in there.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Configs/.config/wezterm/hyde.lua`:
- Around line 29-40: The hyde.lua configuration must account for WezTerm
versions required by wezterm.config_builder(). Declare the minimum supported
version as part of HyDE’s configuration/documentation, or replace the direct
config_builder() usage with a safe compatibility fallback for older builds while
preserving the current configuration behavior.

In `@Configs/.local/share/wallbash/theme/wezterm.dcol`:
- Around line 1-3: Move the WezTerm template referenced by wezterm.dcol from the
Wallbash data-tree location into the deployed
Configs/.config/hyde/wallbash/theme directory, or add an explicit deployment
rule that syncs its current location. Ensure Wallbash deployment includes the
template at runtime.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ea059be4-e732-4530-9b8b-915b3218823b

📥 Commits

Reviewing files that changed from the base of the PR and between aedfb48 and 386e070.

📒 Files selected for processing (2)
  • Configs/.config/wezterm/hyde.lua
  • Configs/.local/share/wallbash/theme/wezterm.dcol

Comment thread Configs/.config/wezterm/hyde.lua Outdated
Comment thread Configs/.local/share/wallbash/theme/wezterm.dcol Outdated
@RAprogramm

Copy link
Copy Markdown
Author

Done your way. Config and template now live in terminal-emulators: HyDE-Project/terminal-emulators#5 adds dots.toml at the root plus wezterm/hyde.lua, and this PR is down to the metafile mirroring it, the terminal registration and the group entry — 27 lines, no duplicated config.

Two notes from reading the installer. The blob+ prefix sends a .zip into the single-file path, so the source is a plain URL. And _discover_extracted_root strips the archive's top-level directory, so paths are written relative to the repository root.

Merge #5 first, this one depends on it.

@RAprogramm

Copy link
Copy Markdown
Author

Metafile now points at the archive: source on the dot, paths relative to the repository root, three entries mirroring dots.toml there. HyDE-Project/terminal-emulators#5 is merged, so the files exist.

The suite will stay red here until #1883 lands — the path check resolves source_root against this checkout, which is wrong for a remote source. That PR exempts them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants