#1889 fix: point shipped callers at files that still exist - #1890
Open
RAprogramm wants to merge 1 commit into
Open
#1889 fix: point shipped callers at files that still exist#1890RAprogramm wants to merge 1 commit into
RAprogramm wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR updates HyDE’s Lua configuration references, replaces retired theme and launch commands, removes obsolete keybind configuration paths, adds system monitor terminal configuration, and introduces tests for stale references. ChangesLua migration cleanup
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1889
Hard failures
hyde-shell themeswitchdid not exist.themeswitch.shwas deleted by6eb07e2dandScripts/migrations/v26.7.4.sh:35retires the leftover, andhyde-shellhas no alias table —run_commandtries.lua,.sh,.py, executable — so every call hard-failed. Repointed attheme.switchinConfigs/.local/share/waybar/modules/custom-theme.jsonc,modules/custom-hyde-menu.jsonc,layouts/macos.jsonc, and attheme.switch.shinConfigs/.local/lib/hyde/wallpaper.kon.sh(reachable from Dolphin's "Set As Wallpaper", shipped byScripts/dots/dolphin.toml:11-19).The config editor created dead files.
config-registry.tomlofferedhypr/{userprefs,keybindings,windowrules,nvidia}.conf, none of which anything loads.hydectlflags a missing entry in the list, butconfig.EditConfigFilerunsExpandPath→os.MkdirAll→$EDITORwithout stat'ing the target, so accepting one created the directory and, on save, a file Hyprland never reads. The four entries collapse into one pointing at${XDG_CONFIG_HOME}/hypr/hyprland.lua, which is where user overrides actually belong (Scripts/dots/hyprland.toml:23-27,preserve).Environment variable
The deployed entry point is
${XDG_DATA_HOME}/hypr/hyde.lua(Scripts/dots/hyprland.toml:11-16).Configs/.config/fish/conf.d/hyde.fish:77exported a.confdeleted by the Lua release, andConfigs/.config/uwsm/env-hyprland.d/00-hyde.sh:28defaulted tohypr/hyprland.lua, which no dot deploys. Fish now walks the same candidate list asshell/activate:49-61, and uwsm defaults tohyde.lua.Both were scoped rather than fatal —
00-hyde.shsourcesactivatefirst, andactivateresetsHYPRLAND_CONFIGbefore setting it — so this bites the session that never activates, the case in discussion #1849, where the reporter quotes the fish line and the maintainer answers-c $XDG_DATA_HOME/hypr/hyde.lua. It also fed the"${HYPRLAND_CONFIG##*.}" == "lua"branches intheme.switch.sh:126-141,color.set.sh:7andcolor/hypr.sh:208.System monitor
system.monitor.sh:63, reachable fromCTRL + SHIFT + ESCAPE, read the terminal out of the deleted~/.config/hypr/keybindings.conf— and$termwas first assigned on that very line, so the pattern was a bare^\s*and the grep never meant anything even before the deletion. Removed. The documented fallback did not exist either:SYSMONITOR_TERMINALappeared only in the script'sshow_help, soterminalis now declared inschema/config.tomlandschema/schema.toml. With neither that norTERMINALset the script warns and moves to the next candidate instead of launching a console monitor with no terminal attached.Dead code
hyde-launch.sh:6called the deletedopen.sh; it now callshyde-shell open. Nothing in the tree invokeshyde-launch— a full grep finds only its own deprecation notice — so this is cosmetic; deleting the file instead would be equally correct.keybinds_hint.sh:6-7seededkb_hint_conffrom three deleted.confpaths and never read the variable again;ROFI_KEYBIND_HINT_CONFIGappears nowhere else. The hint reads live binds viakeybinds/hint-hyprland.py, so the assignment and the two variables feeding it are gone. Note #1826 and #1775 also touch this file; the removed lines are not the ones they edit.Deliberately not touched
globalcontrol.sh:335-340andluautils/theme/parser.lua:134-141still list${XDG_DATA_HOME}/hyde/{hyde,hyprland}.confamong six default-config paths. Those two are no longer deployed, but the primary source$HYDE_THEME_DIR/hypr.themestill answers and the six-path grep is a last resort that now returns empty rather than failing — and a user may legitimately keep their own copy there. Left for a separate decision.Configs/.local/lib/hyde/grimblastis referenced by nothing:screenshot.shandscreenrecord.shboth invoke$LIB_DIR/hyde/screenshot/grimblast, the vanilla copy the[grimblast]dot downloads. Worth noting because #1877 fixes the double selection in the in-repo file, which nothing runs — the live bug is in the downloaded script.Tests
tests/test_references.sh(new) fails on the pre-change tree with 14 failures and passes after: it rejects any shipped config referencinghyde-shell themeswitch,themeswitch.sh,hyde/open.shor the four retiredhypr/*.confpaths, asserts the Lua entry point exists, and requires every shell integration that setsHYPRLAND_CONFIGto point athypr/hyde.lua. The legacyScripts/restore_cfg.*pair is out of scope, documented in the test.Full suite: 9 cases, 0 failed.
Summary by CodeRabbit
Bug Fixes
New Features
Tests