Skip to content

Revert "#1891 docs: describe the Lua keybind configuration and add a transition guide" - #1896

Closed
kRHYME7 wants to merge 1 commit into
devfrom
revert-1892-1891
Closed

Revert "#1891 docs: describe the Lua keybind configuration and add a transition guide"#1896
kRHYME7 wants to merge 1 commit into
devfrom
revert-1892-1891

Conversation

@kRHYME7

@kRHYME7 kRHYME7 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Reverts #1892

Summary by CodeRabbit

  • Documentation
    • Updated configuration guidance with clearer instructions for adding overrides and loading additional files.
    • Revised Hyprland setup documentation and corrected links to translated keybinding references.
    • Streamlined the keybinding reference, including updated actions, simplified focus switching, and removed obsolete bindings.
    • Removed the Lua migration guide and several outdated changelog documentation entries.
    • Clarified custom keybinding setup with an example for adding a game launcher shortcut.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 10c59f76-b2bf-41d0-a0e3-96a3de3de52d

📥 Commits

Reviewing files that changed from the base of the PR and between 4b98183 and 7f2a9f3.

📒 Files selected for processing (11)
  • CHANGELOG.md
  • Configs/.config/hypr/hyprland.lua
  • Hyprdots-to-HyDE.md
  • KEYBINDINGS.md
  • MIGRATION-LUA.md
  • Source/docs/README.ar.md
  • Source/docs/README.de.md
  • Source/docs/README.fr.md
  • Source/docs/README.nl.md
  • Source/docs/README.tr.md
  • tests/lua/bind_harness.lua

📝 Walkthrough

Walkthrough

The pull request revises keybinding documentation, Lua configuration comments, Hyprland guidance, localized README links, changelog entries, and Lua harness expectations.

Changes

Keybinding documentation alignment

Layer / File(s) Summary
Update keybinding reference and validation
KEYBINDINGS.md, tests/lua/bind_harness.lua
Keybinding tables and custom-binding instructions were revised, while the Lua harness checks a reduced documented bind set.
Revise Lua configuration guidance
Configs/.config/hypr/hyprland.lua, Hyprdots-to-HyDE.md, CHANGELOG.md
Lua comments and Hyprland setup guidance were replaced or shortened, and documentation changelog entries were removed.
Correct localized documentation links
Source/docs/README.*.md
Localized README navigation links now reference keybinding documents from their current location.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

Suggested labels: bug

Suggested reviewers: raprogramm

Poem

I’m a rabbit with bindings to trim,
Keys hop neatly, while old rows grow dim.
Lua whispers, “require” with care,
Links now leap to the documents there.
Tests nibble the shortcuts that swim.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-1892-1891

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kRHYME7 kRHYME7 closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant