fix jq path to match postgresql lax jsonpath for load-legacy-tests - #235
Merged
Conversation
willr3
force-pushed
the
issue_230_fix_lax_sql_to_jq
branch
4 times, most recently
from
August 4, 2026 14:37
fca15b8 to
c13bc4b
Compare
stalep
reviewed
Aug 4, 2026
stalep
left a comment
stalep
left a comment
Member
There was a problem hiding this comment.
Looks good, I just had two minor comments
| TransactionManager tm; | ||
|
|
||
| @Test | ||
| public void workers(){ |
Collaborator
Author
There was a problem hiding this comment.
removed along with the unused valueService
| LoadLegacyTests.Extractor results = new LoadLegacyTests.Extractor("results","$.results.*",true); | ||
| LoadLegacyTests.Label label = new LoadLegacyTests.Label(-1,"Autobench", | ||
| "v => v[\"results\"].reduce((a,b) => a+b) / v[\"results\"].length", | ||
| "v => v[\"results\"].reduce((a,b) => a+b) / v[\"results\"].stop", |
Collaborator
Author
There was a problem hiding this comment.
because I failed with the scope of a variable rename and thought I fixed them all but missed one :)
willr3
force-pushed
the
issue_230_fix_lax_sql_to_jq
branch
from
August 4, 2026 17:18
c13bc4b to
1cbb905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #230 by changing how jq operations are created for Horreum extractor paths. The new jq operations will check each key in a chain of keys to handle the auto array expansion that occurs in postgresql lax jsonpath.