-
Notifications
You must be signed in to change notification settings - Fork 13
Update catcodes, obscodes with program codes #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ben-cassese
wants to merge
3
commits into
IAU-ADES:master
Choose a base branch
from
ben-cassese:update_catcodes_obscodes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not enjoy that this list is hard-coded into here... Maybe in the near future, we should add the
has_prog_codecolumn of theobscodestable to the public replication, so that the obscodes API (https://docs.minorplanetcenter.net/mpc-ops-docs/apis/obscodes/#response-fields-json-format) could be used to figure out the most up to date list of obscodes that use program codes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it either, but a decision was made early on, at the request of some observers, that the ADES tools should not rely on a network connection.
Maybe that is so 2015 and it should be revisited. In that case the validator could also check the MPC-maintained list for mode, notes, astCat, etc.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relying on a network connection remains iffy for those in remote locations. But it should be acceptable to require that you have files listing modes, notes, etc. present when you run the tools, and to point out that you'll have to update those files every now and then if you use the latest and greatest modes, notes, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not a fan of the hard-coded lists. Perhaps a hybrid approach can be taken where the list of allowable values for program codes (and others) are stored in a data file that is distributed with this code. We can then populate the data file with the MPC APIs at build-time and release it along with the code in our PyPI versioned releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to Mike about this and we also had an internal discussion with Peter W about the possibility of changing the hard-coded list to something more API-driven. At the moment, Peter, even though not a fan of the hard-coded lists, would prefer to maintain the code as it is. We might want to revisit it in the future. Thank you all.