fix(ibm-integer-attributes): add validation for type integer ranges - #756
Conversation
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
|
I'm not sure the tests are enough to cover the implemented behaviour or if they are written in the right way to test this kind of behaviour. Feedback is appreciated! |
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
|
|
|
|
diatrcz
changed the title
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
| errors.push({ | ||
| message: `'minimum' value is out of safe range`, | ||
| path, | ||
| }); | ||
| } |
There was a problem hiding this comment.
We might not want to gate this on maximum also being defined (and corresponding feedback for the three below).
Co-authored-by: Dan Hudlow <dhudlow@us.ibm.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
## @ibm-cloud/openapi-ruleset [1.31.2](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.31.1...@ibm-cloud/openapi-ruleset@1.31.2) (2025-08-04) ### Bug Fixes * **ibm-integer-attributes:** add validation for type integer ranges ([#756](#756)) ([3d5f9f4](3d5f9f4))
|
🎉 This PR is included in version 1.31.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
## ibm-openapi-validator [1.35.3](https://github.com/IBM/openapi-validator/compare/ibm-openapi-validator@1.35.2...ibm-openapi-validator@1.35.3) (2025-08-04) ### Bug Fixes * **ibm-integer-attributes:** add validation for type integer ranges ([#756](#756)) ([3d5f9f4](3d5f9f4)) ### Dependencies * **@ibm-cloud/openapi-ruleset:** upgraded to 1.31.2
|
🎉 This PR is included in version 1.35.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
5 participants
PR summary
Adds validation for integers to check if maximum and minimum attributes are within safe ranges.
The minimum and maximum range checks are set according to the api handbook.
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:
.secrets.baselinehas been updated as needednpm run update-utilitieshas been run if any files inpackages/utilities/srchave been updatedChecklist for adding a new validation rule: