Skip to content

fix(ibm-operationid-naming-convention): make full naming check optional - #764

Merged
diatrcz merged 5 commits into
mainfrom
lt/op-naming-fix
Sep 25, 2025
Merged

fix(ibm-operationid-naming-convention): make full naming check optional#764
diatrcz merged 5 commits into
mainfrom
lt/op-naming-fix

Conversation

@diatrcz

@diatrcz diatrcz commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

PR summary

Modifies the ibm-operationid-naming-convention rule, so the operationid name validation can be switched off.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline has been updated as needed
  • npm run update-utilities has been run if any files in packages/utilities/src have been updated

Checklist for adding a new validation rule:

  • Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
  • If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
  • Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
  • Added tests for new rule (packages/ruleset/test/*.test.js)
  • Added docs for new rule (docs/ibm-cloud-rules.md)
  • Added scoring rubric entry for new rule (packages/validator/src/scoring-tool/rubric.js)

…ecks optional

Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
@diatrcz
diatrcz requested a review from pyrooka September 23, 2025 14:14
@diatrcz diatrcz changed the title fix(ibm-operationid-naming-convention): make full operationid name ch… fix(ibm-operationid-naming-convention): make namecheck optional Sep 23, 2025
@diatrcz diatrcz changed the title fix(ibm-operationid-naming-convention): make namecheck optional fix(ibm-operationid-naming-convention): make full naming check optional Sep 23, 2025
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! 🚀

@diatrcz
diatrcz merged commit 67a2f97 into main Sep 25, 2025
7 checks passed
@diatrcz
diatrcz deleted the lt/op-naming-fix branch September 25, 2025 10:02
ibm-devx-sdk pushed a commit that referenced this pull request Sep 25, 2025
## @ibm-cloud/openapi-ruleset [1.33.1](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.33.0...@ibm-cloud/openapi-ruleset@1.33.1) (2025-09-25)

### Bug Fixes

* **ibm-operationid-naming-convention:** make full naming check optional ([#764](#764)) ([67a2f97](67a2f97))
@ibm-devx-sdk

Copy link
Copy Markdown

🎉 This PR is included in version 1.33.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk

Copy link
Copy Markdown

🎉 This PR is included in version 1.37.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk

Copy link
Copy Markdown

🎉 This PR is included in version 1.9.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants