Skip to content

Fix GO UI issues#2305

Draft
frozenhelium wants to merge 1 commit intodocs/update-collaboration-docsfrom
chore/fix-ui-issues
Draft

Fix GO UI issues#2305
frozenhelium wants to merge 1 commit intodocs/update-collaboration-docsfrom
chore/fix-ui-issues

Conversation

@frozenhelium
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium commented Apr 3, 2026

Bugs fixes:

  • Fix swapped Up/Down enum values and increment direction in useKeyboard
  • Fix next-page button title off-by-one in Pager (activePage-1 → activePage+1)
  • Fix formatNumber currency option type (boolean → string) to prevent RangeError
  • Fix addNumMonthsToDate NaN check to use .getTime() on Date object

Accessibility:

  • Modal: add role=dialog, aria-modal, aria-labelledby via useId
  • ProgressBar: add role=progressbar with aria-valuenow/min/max
  • Tooltip: add focusin/focusout handlers; add role=tooltip on popup
  • Tab: add role=tab and aria-selected on RawButton
  • DropdownMenu: add aria-expanded, aria-haspopup=menu; role=menu on popup
  • Checkbox: fix label/input association with useId + explicit id/htmlFor
  • Popup: add role prop to support tooltip and menu roles

CSS tokens:

  • Fix --go-ui-font-weight-bold token value (600 → 700)
  • Replace pt units with px across separator and box-shadow tokens
  • Namespace --base-font-size and --base-spacing with --go-ui- prefix

Hooks:

  • useFloatPlacement: move getComputedStyle out of module scope to fix SSR crash
  • useSpacingToken: replace per-instance style tag injection with shared
    element + ref-count map to eliminate duplicate CSS rules

Exports:

  • Add missing TextBadge, LegendProps, TopBannerProps, ChartContainerProps,
    TabListProps exports from src/index.tsx

package.json:

  • Remove react-focus-on and sanitize-html from devDependencies (duplicated)
  • Bump @ifrc-go/icons peer dep to ^2.0.1 to match runtime dependency
  • Move jiti to devDependencies

Bugs fixes:

- Fix swapped Up/Down enum values and increment direction in useKeyboard
- Fix next-page button title off-by-one in Pager (activePage-1 → activePage+1)
- Fix formatNumber currency option type (boolean → string) to prevent RangeError
- Fix addNumMonthsToDate NaN check to use .getTime() on Date object

Accessibility:

- Modal: add role=dialog, aria-modal, aria-labelledby via useId
- ProgressBar: add role=progressbar with aria-valuenow/min/max
- Tooltip: add focusin/focusout handlers; add role=tooltip on popup
- Tab: add role=tab and aria-selected on RawButton
- DropdownMenu: add aria-expanded, aria-haspopup=menu; role=menu on popup
- Checkbox: fix label/input association with useId + explicit id/htmlFor
- Popup: add role prop to support tooltip and menu roles

CSS tokens:

- Fix --go-ui-font-weight-bold token value (600 → 700)
- Replace pt units with px across separator and box-shadow tokens
- Namespace --base-font-size and --base-spacing with --go-ui- prefix

Hooks:

- useFloatPlacement: move getComputedStyle out of module scope to fix SSR crash
- useSpacingToken: replace per-instance style tag injection with shared
  element + ref-count map to eliminate duplicate CSS rules

Exports:

- Add missing TextBadge, LegendProps, TopBannerProps, ChartContainerProps,
  TabListProps exports from src/index.tsx

package.json:

- Remove react-focus-on and sanitize-html from devDependencies (duplicated)
- Bump @ifrc-go/icons peer dep to ^2.0.1 to match runtime dependency
- Move jiti to devDependencies
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2026

⚠️ No Changeset found

Latest commit: c2a09b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frozenhelium frozenhelium changed the base branch from develop to docs/update-collaboration-docs April 3, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant