Fix GO UI issues#2305
Draft
frozenhelium wants to merge 1 commit intodocs/update-collaboration-docsfrom
Draft
Conversation
Bugs fixes: - Fix swapped Up/Down enum values and increment direction in useKeyboard - Fix next-page button title off-by-one in Pager (activePage-1 → activePage+1) - Fix formatNumber currency option type (boolean → string) to prevent RangeError - Fix addNumMonthsToDate NaN check to use .getTime() on Date object Accessibility: - Modal: add role=dialog, aria-modal, aria-labelledby via useId - ProgressBar: add role=progressbar with aria-valuenow/min/max - Tooltip: add focusin/focusout handlers; add role=tooltip on popup - Tab: add role=tab and aria-selected on RawButton - DropdownMenu: add aria-expanded, aria-haspopup=menu; role=menu on popup - Checkbox: fix label/input association with useId + explicit id/htmlFor - Popup: add role prop to support tooltip and menu roles CSS tokens: - Fix --go-ui-font-weight-bold token value (600 → 700) - Replace pt units with px across separator and box-shadow tokens - Namespace --base-font-size and --base-spacing with --go-ui- prefix Hooks: - useFloatPlacement: move getComputedStyle out of module scope to fix SSR crash - useSpacingToken: replace per-instance style tag injection with shared element + ref-count map to eliminate duplicate CSS rules Exports: - Add missing TextBadge, LegendProps, TopBannerProps, ChartContainerProps, TabListProps exports from src/index.tsx package.json: - Remove react-focus-on and sanitize-html from devDependencies (duplicated) - Bump @ifrc-go/icons peer dep to ^2.0.1 to match runtime dependency - Move jiti to devDependencies
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixes:
Accessibility:
CSS tokens:
Hooks:
element + ref-count map to eliminate duplicate CSS rules
Exports:
TabListProps exports from src/index.tsx
package.json: