IGVF-3614-encode-measurement - #2164
Merged
Merged
Conversation
jenjou
reviewed
Jul 27, 2026
| "title": "External identifier", | ||
| "description": "Identifier from an external resource that may have 1-to-1 or 1-to-many relationships with IGVF file sets.", | ||
| "type": "string", | ||
| "pattern": "^(GEO:GSE\\d+|urn:mavedb:\\d{8}-[0a-z]+-\\d+|ENCODE:.+)$" |
Contributor
There was a problem hiding this comment.
Should the regex for ENCODE be more strict to exactly match an ENCODE accession, or do we not require that?
Contributor
Author
There was a problem hiding this comment.
I can make it specific to experiments, i.e. ENCSR* if that is what you are proposing
Contributor
Author
There was a problem hiding this comment.
But I did just copy this from the existing regex in reference files
jenjou
approved these changes
Jul 27, 2026
ian-whaling
force-pushed
the
IGVF-3614-encode-measurement
branch
from
July 27, 2026 21:32
7fe07ab to
ae8ed90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.