Update getSequences to also return ranges with sequence behavior#84
Open
MImranAsghar wants to merge 1 commit into
Open
Update getSequences to also return ranges with sequence behavior#84MImranAsghar wants to merge 1 commit into
MImranAsghar wants to merge 1 commit into
Conversation
.. Seq behavior
Member
|
Change looks good. This will be a breaking change for the UV as it sometimes casts the output of const sequences: Array<Sequence> = manifest.getSequences();I know #79 brings the interfaces closer, but do you think we should align the interfaces so we have something like: interface SequenceInterface {}
class Sequence implements SequenceInterface {}
class Range implements SequenceInterface /* other interfaces? [...] */ {}
class Manifest {
// ...
getSequences(): SequenceInterface[] { /* ... */ }
} |
Author
|
Hi @stephenwf , just to make sure i understand correctly, in this case sequence interface would list out the definitions for all functions and types needed for sequence and be implemented by the Sequence and Range classes, and the implementation of those functions like getCanvases would be within each range.ts (like #79) and sequence.ts. So in that case we can use the sequence interface as a type instead of Sequence | Range for getSequences()? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.