Skip to content

Dataset Type selection step in Create Dataset page#876

Open
g-saracca wants to merge 34 commits intodevelopfrom
797-dataset-type-selection-step
Open

Dataset Type selection step in Create Dataset page#876
g-saracca wants to merge 34 commits intodevelopfrom
797-dataset-type-selection-step

Conversation

@g-saracca
Copy link
Copy Markdown
Contributor

@g-saracca g-saracca commented Oct 20, 2025

What this PR does / why we need it:

Following up on @pdurbin's work in #845, this PR updates how users select the dataset type in the dataset creation flow.

For now, we’ve hardcoded the dataset type descriptions (“dataset” and “review”) as a temporary solution until the new field is added. Update: this was fixed in 7c355f4.

This is the first step toward supporting dataset types in the SPA, more enhancements coming soon.

Storybook links:

Which issue(s) this PR closes:

Depends on

This PR depends on the following backend PR:

Special notes for your reviewer:

Suggestions on how to test this:

Pre-requisites for testing this.

As mentioned in IQSS/dataverse#11753:

Do all the setup at https://dataverse-guide--11753.org.readthedocs.build/en/11753/admin/dataverses-datasets.html#review-datasets-setup
  1. Login within the SPA and navigate to the Create Dataset page.
  2. By default only one dataset type exists('dataset' type) so you won't see a Dataset Type selector.
  3. Add a new dataset type with:
curl -H "X-Dataverse-key:$API_TOKEN" -H "Content-Type: application/json" "http://localhost:8080/api/datasets/datasetTypes" -X POST -d '{"name":"review","linkedMetadataBlocks":["geospatial"]}'
  1. Navigate again to the Create Dataset Page and now you will see a Dataset Type selector.
  2. Select "Review" and create the dataset.
  3. Go to edit the recently created dataset and you will se a Dataset Type readonly field with the value of "Review".

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes.

The "Create Dataset" page now has a Dataset Type dropdown. See the latest screenshots here: #876 (comment)

Is there a release notes or changelog update needed for this change?:

Not for now, might be good to add it after work related to dataset types is done.

Additional documentation:

@github-actions github-actions bot added the GREI Re-arch GREI re-architecture-related label Oct 20, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 20, 2025

Coverage Status

coverage: 97.296% (-0.04%) from 97.339% — 797-dataset-type-selection-step into develop

@pdurbin pdurbin self-assigned this Jan 12, 2026
@pdurbin pdurbin moved this from SPRINT READY to In Progress 💻 in IQSS Dataverse Project Jan 12, 2026
@pdurbin pdurbin marked this pull request as draft January 12, 2026 19:06
Conflicts:
package-lock.json
package.json
src/dataset/domain/repositories/DatasetRepository.ts
src/stories/dataset/DatasetErrorMockRepository.ts
src/stories/dataset/DatasetMockRepository.ts
@pdurbin pdurbin added the Size: 50 A percentage of a sprint. 35 hours. label Jan 14, 2026
@cmbz cmbz added the FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) label Jan 15, 2026
@pdurbin pdurbin moved this from In Progress 💻 to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Jan 28, 2026
@pdurbin pdurbin removed their assignment Jan 28, 2026
@pdurbin pdurbin moved this from This Sprint 🏃‍♀️ 🏃 to On Hold ⌛ in IQSS Dataverse Project Jan 28, 2026
Conflicts:
src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts
src/sections/create-dataset/CreateDataset.tsx
src/sections/shared/form/DatasetMetadataForm/MetadataForm/index.tsx
src/sections/shared/form/DatasetMetadataForm/index.tsx
src/stories/create-dataset/CreateDataset.stories.tsx
src/stories/dataset/DatasetErrorMockRepository.ts
src/stories/dataset/DatasetMockRepository.ts
tests/component/sections/create-dataset/CreateDataset.spec.tsx
tests/component/sections/layout/header/LoggedInHeaderActions.spec.tsx
@pdurbin
Copy link
Copy Markdown
Member

pdurbin commented Feb 10, 2026

As a reminder, in the frontend (this PR) these descriptions are currently hard-coded to the values in the screenshot below. They should be retrieved dynamically from the backend instead.

I just fixed this in 7c355f4. It looks like this after running mvn test -Dtest=DatasetTypesIT#testCreateReview, which doesn't add descriptions or dataset types it adds for testing:

Screenshot 2026-02-10 at 2 51 36 PM

@pdurbin
Copy link
Copy Markdown
Member

pdurbin commented Mar 4, 2026

Here are updated screenshots as of IQSS/dataverse@be670d4 where @scolapasta and I decided to make some changes to the backend.

We're now using the linkedMetadataBlocks features and setting itemReviewedUrl and itemReviewedType as required=true in the tsv.

In the collection below, we are allowing both "Dataset" and "Review" under "Dataset Type".

Screenshot 2026-03-04 at 10 41 56 AM

Here is the creation of a review dataset. Note that the "Review Metadata" metadata block is present, which is what we want, of course.

Screenshot 2026-03-04 at 10 42 18 AM Screenshot 2026-03-04 at 10 45 20 AM Screenshot 2026-03-04 at 10 46 02 AM

Here is the creation of a regular dataset. Note that the "Review Metadata" metadata block is absent. This is what we want because having "Item Reviewed" as a required field doesn't make sense for a dataset.

Screenshot 2026-03-04 at 10 47 03 AM

@pdurbin pdurbin moved this from On Hold ⌛ to SPRINT READY in IQSS Dataverse Project Mar 10, 2026
@pdurbin pdurbin moved this from SPRINT READY to Ready for Review ⏩ in IQSS Dataverse Project Mar 10, 2026
@pdurbin pdurbin added Size: 10 A percentage of a sprint. 7 hours. and removed Size: 50 A percentage of a sprint. 35 hours. labels Mar 10, 2026
@pdurbin pdurbin marked this pull request as ready for review March 10, 2026 13:50
@pdurbin
Copy link
Copy Markdown
Member

pdurbin commented Mar 10, 2026

The PR was on hold because we were waiting for the backend code to be merged, which happened yesterday.

  • #11753

I moved it to "ready for review".

@pdurbin pdurbin moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Mar 10, 2026
@cmbz cmbz added the FY26 Sprint 18 FY26 Sprint 18 (2026-02-25 - 2026-03-11) label Mar 11, 2026
@cmbz cmbz added this to the 6.11 milestone Mar 11, 2026
@cmbz cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Mar 27, 2026
@cmbz cmbz added Size: 20 A percentage of a sprint. 14 hours. FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) and removed Size: 10 A percentage of a sprint. 7 hours. labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) FY26 Sprint 18 FY26 Sprint 18 (2026-02-25 - 2026-03-11) FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) GREI Re-arch GREI re-architecture-related Project: Trusted Data Size: 20 A percentage of a sprint. 14 hours.

Projects

Status: In Progress 💻

Development

Successfully merging this pull request may close these issues.

Dataset Type facet doesn't work, no matches Allow for the creation of various dataset types

5 participants