Skip to content

Add warning message to login page#932

Open
ChengShi-1 wants to merge 8 commits intodevelopfrom
930-add-warning-message-to-login-page
Open

Add warning message to login page#932
ChengShi-1 wants to merge 8 commits intodevelopfrom
930-add-warning-message-to-login-page

Conversation

@ChengShi-1
Copy link
Copy Markdown
Contributor

@ChengShi-1 ChengShi-1 commented Mar 20, 2026

What this PR does / why we need it:

Like the description in the issue, to avoid confusion of users when they sign in, we need to add a note/alert on the Harvard SPA login page to clarify that some of the available login options are not supported.
Besides the text, I also add a navigation to sign up an account in JSF.

Which issue(s) this PR closes:

Special notes for your reviewer:

For next steps to apply this in production, refer to docs/KEYCLOAK_DEPLOYMENT.md, we will need to

  1. npm run build-keycloak-theme, This generates dist_keycloak/dv-spa-kc-theme.jar
  2. Deploy that JAR to the production Keycloak instance. Copy dist_keycloak/dv-spa-kc-theme.jar into Keycloak’s providers/ directory
  3. Restart Keycloak to reload the provider/theme JAR
  4. Also, Confirm the production realm is using the dataverse-spa login theme(Realm Settings -> Themes -> Login Theme -> dataverse-spa)

Suggestions on how to test this:

See how to build keycloak in this doc

Then, go to spa => sign in, the note and styled log in page should be shown

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

image ## Is there a release notes or changelog update needed for this change?:

Additional documentation:

@ChengShi-1 ChengShi-1 linked an issue Mar 20, 2026 that may be closed by this pull request
@github-actions github-actions bot added FY26 Sprint 19 FY26 Sprint 19 (2026-03-11 - 2026-03-25) GREI Re-arch GREI re-architecture-related Project: HDV SPA Rollout labels Mar 20, 2026
@ChengShi-1 ChengShi-1 added the Size: 3 A percentage of a sprint. 2.1 hours. label Mar 20, 2026
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project Mar 20, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 20, 2026

Coverage Status

coverage: 97.365% (+0.07%) from 97.297% — 930-add-warning-message-to-login-page into develop

@ChengShi-1 ChengShi-1 marked this pull request as ready for review March 20, 2026 22:41
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Mar 20, 2026
@ChengShi-1 ChengShi-1 self-assigned this Mar 20, 2026
@ChengShi-1 ChengShi-1 moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Mar 23, 2026
@ChengShi-1 ChengShi-1 removed their assignment Mar 23, 2026
@ekraffmiller ekraffmiller self-assigned this Mar 24, 2026
@ekraffmiller ekraffmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 24, 2026
@ekraffmiller
Copy link
Copy Markdown
Contributor

Fyi, I removed the HDV SPA Rollout label, because we won't need this for our end of March deployment. The power users won't be logging in to the production environment, they will use Demo instead.

@cmbz cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Mar 27, 2026
@ekraffmiller
Copy link
Copy Markdown
Contributor

This looks good, but I think given the known issues we have with users that have '@' in their username, I think it would be good to update the message to 'Note about CILogin', rather than a note about Github, Google and Orchid users.

@ChengShi-1
Copy link
Copy Markdown
Contributor Author

Hi @ekraffmiller , I just changed the text to "CILOGON options"
image

Copy link
Copy Markdown
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just thinking that in order to easily remove it when it's no longer needed, can you create a separate component for the warning message?

@cmbz cmbz added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 19 FY26 Sprint 19 (2026-03-11 - 2026-03-25) FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) GREI Re-arch GREI re-architecture-related Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: In Review 🔎

Development

Successfully merging this pull request may close these issues.

Add Warning Message to Login page

4 participants