Replace hard-coded references from /spa to /modern#952
Open
ChengShi-1 wants to merge 4 commits intodevelopfrom
Open
Replace hard-coded references from /spa to /modern#952ChengShi-1 wants to merge 4 commits intodevelopfrom
ChengShi-1 wants to merge 4 commits intodevelopfrom
Conversation
github-actions
bot
added
FY26 Sprint 21
|
coverage: 97.358% (+0.06%) from 97.297% — Remove'/SPA' into develop |
ekraffmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good! Just need to resolve merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to be able to rebrand the SPA as the 'Modern' frontend. To do this, we need to replace hard-coded references to the /spa path with something dynamic.
Which issue(s) this PR closes:
Special notes for your reviewer:
Source code: vite.config.ts, dev-env/vite.config.ts, package.json, src/i18n.ts, Header.tsx, FeaturedItemsFormHelper.ts, NotImplementedModal.tsx, Layout.tsx
CI/CD & infra: deploy-beta-testing.yml, deploy.yml, generate-war.yml, nginx.conf (x2)
Tests: cypress.config.ts, new basePath.ts, 12 E2E spec files, commands.tsx, component tests & mocks
Docs: README.md, DEVELOPER_GUIDE.md
Keycloak-related files are unchanged
Suggestions on how to test this:
Test with new url http://localhost:8000/modern
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No UI change, just the url path
Is there a release notes or changelog update needed for this change?:
Yes, changelog and some other docs
Additional documentation: