⚡ perf(catalog): optimize get_service call - #9442
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9442 +/- ##
===========================================
- Coverage 88.18% 77.01% -11.18%
===========================================
Files 1559 311 -1248
Lines 60596 16388 -44208
Branches 1583 203 -1380
===========================================
- Hits 53436 12621 -40815
+ Misses 6739 3715 -3024
+ Partials 421 52 -369
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Pull request overview
Optimizes catalog service retrieval by reusing database connections and avoiding a redundant permission query.
Changes:
- Reuses one connection across access-rights and service queries.
- Adds optional connection support to repository read methods.
- Simplifies result loading and validation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
service/catalog_services.py |
Optimizes service retrieval and centralizes access-right validation. |
repository/services.py |
Supports shared connections for service queries. |
repository/groups.py |
Supports shared connections and simplifies result validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
get_service call
bisgaard-itis
left a comment
There was a problem hiding this comment.
Thanks a lot for the effort 🙏🏻
Com'on! This was an easy one :D |
b722465
into
ITISFoundation:master



What do these changes do?
This PR optimizes the repository worflow for the
get_servicecall.For each
get_catalog_servicecall, this spares:can_get_serviceSQL query, reducing queries from 4 to 3.Related issue/s
How to test
Dev-ops