dynamic-scheduler now uses RPC to reach the catalog - #9599
Merged
mergify[bot] merged 2 commits intoAug 28, 2026
Merged
Conversation
github-actions
Bot
added
a:infra+ops
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9599 +/- ##
==========================================
- Coverage 88.18% 88.16% -0.03%
==========================================
Files 1563 1559 -4
Lines 60661 60596 -65
Branches 1583 1583
==========================================
- Hits 53496 53424 -72
- Misses 6743 6751 +8
+ Partials 422 421 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
GitHK
changed the title
dynamic-scheduler now uses RPC to reach the catalog
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors dynamic-scheduler to use the Catalog RabbitMQ RPC interface (instead of HTTP) when retrieving service docker-image labels, and extends the Catalog RPC surface to expose get_service_labels end-to-end.
Changes:
- Switch
dynamic-schedulerstop logic to fetch service labels viaservicelib.rabbitmq.rpc_interfaces.catalog.services.get_service_labels(...). - Remove the
dynamic-schedulerHTTP thin/public Catalog clients and their related app settings and docker-compose env wiring. - Add
get_service_labelsto Catalog’s RPC server, the shared service-library RPC client, and test/support helpers (plus a Catalog unit test).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/dynamic-scheduler/tests/unit/services/test_catalog.py | Removes HTTP-based Catalog client unit tests (client removed). |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/common_interface.py | Uses Catalog RPC (get_service_labels) to decide legacy vs dynamic-sidecar stop behavior. |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/catalog/_thin_client.py | Removes HTTP thin client implementation. |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/catalog/_setup.py | Removes Catalog client lifespan/plugin setup. |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/catalog/_public_client.py | Removes HTTP public client wrapper. |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/catalog/init.py | Removes Catalog client exports. |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/settings.py | Removes Catalog HTTP settings from dynamic-scheduler settings. |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py | Removes Catalog plugin configuration from app composition. |
| services/docker-compose.yml | Drops CATALOG_HOST/PORT envs from the dynamic-scheduler service section. |
| services/catalog/tests/unit/with_dbs/test_api_rpc.py | Adds unit test for Catalog RPC get_service_labels. |
| services/catalog/src/simcore_service_catalog/service/catalog_services.py | Adds service-layer helper to fetch/validate labels from director as SimcoreServiceLabels. |
| services/catalog/src/simcore_service_catalog/api/rpc/_services.py | Exposes get_service_labels over Catalog RPC. |
| packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/services.py | Adds shared RPC client method get_service_labels. |
| packages/pytest-simcore/src/pytest_simcore/helpers/catalog_rpc.py | Extends Catalog RPC test side-effects with get_service_labels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
GitHK
added
the
t:maintenance
GitHK
marked this pull request as ready for review
August 27, 2026 06:27
GitHK
requested review from
YuryHrytsuk,
giancarloromeo,
mrnicegyu11,
pcrespov and
sanderegg
as code owners
August 27, 2026 06:27
giancarloromeo
approved these changes
Aug 27, 2026
pcrespov
approved these changes
Aug 27, 2026
pcrespov
left a comment
pcrespov
left a comment
Member
There was a problem hiding this comment.
thx for following up on this.
…-catalog-client-dynamic-scheduler
Contributor
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 46 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Replaced HTTP client form
dynamic-schedulerwith the RPC one since the HTTP interface of the catalog is deprecated.Related issue/s
How to test
Dev-ops