🐛 Webserver: ensure project-logs unsubscription always runs on disconnect/close - #9607
Open
sanderegg wants to merge 2 commits into
Conversation
sanderegg
added
the
t:maintenance
github-actions
Bot
added
the
a:webserver
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9607 +/- ##
==========================================
- Coverage 88.15% 88.13% -0.02%
==========================================
Files 1559 1559
Lines 60601 60601
Branches 1583 1583
==========================================
- Hits 53421 53412 -9
- Misses 6759 6768 +9
Partials 421 421
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
sanderegg
marked this pull request as ready for review
August 27, 2026 17:41
sanderegg
requested review from
GitHK,
matusdrobuliak66 and
pcrespov
as code owners
August 27, 2026 17:41
Member
Author
|
@mergify queue |
Contributor
Merge Queue Status
Waiting for any of
All conditions
|
matusdrobuliak66
approved these changes
Aug 27, 2026
GitHK
approved these changes
Aug 28, 2026
YuryHrytsuk
approved these changes
Aug 28, 2026
sanderegg
force-pushed
the
maintenance/ensure-rabbitmq-subscribed-topics-are-always-properly-unsubscribed
branch
from
August 28, 2026 16:37
b53335d to
40351a6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Follow-up to the RabbitMQ logs-queue incident : 2 code paths could silently skip unsubscribing a user's session from a project's live-log topic RabbitMQ Queue binding.
Both bugs share the same shape: a fallible RPC-dependent step (a lock-state notification / a dynamic-service-removal or project-state fetch — all of which can time out when RabbitMQ or the dynamic-scheduler is under stress) ran before the log-unsubscription step, with no isolation between them, so a failure in the first step prevented the second from ever running.
_on_user_disconnected(projects/_controller/projects_slot.py, socket disconnect path): the project-locked-state notification and the log-unsubscription were two separate sequential steps — a failure in one can no longer block the other.close_project_for_user(projects/_projects_service.py, RESTclose_project+ garbage-collector path): now the log unsubscription always runs.Related issue/s
How to test
Dev-ops