-
Notifications
You must be signed in to change notification settings - Fork 170
packagess moved, package generator updated, missing fulld_xxx.bat add… #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vincentparrett
wants to merge
11
commits into
IndySockets:Indy-10.7
Choose a base branch
from
vincentparrett:package-restructure
base: Indy-10.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6e2d5ac
packagess moved, package generator updated, missing fulld_xxx.bat add…
vincentparrett 0eb7b9b
review fixes
vincentparrett 4740a5c
removed most uses of %~dp0
vincentparrett 4bfe01e
review changes - moved inc files to Lib\Include, always generate with…
vincentparrett fcf1dd0
Missed a copyright symbol
vincentparrett 58c6f83
Moved source folder from Lib to Lib\Source
vincentparrett ea6f0a5
Updated package generator for new paths
vincentparrett 00809fc
Moved packages to \Lib\Packages
vincentparrett 7813406
Use resinator for RS 13 or later, rc for earlier versions
vincentparrett a98ea87
Changed the generated buildres.bat to decide which resource compiler …
vincentparrett 82ed574
Merge branch 'Indy-10.7' into package-restructure
vincentparrett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [Settings] | ||
| LastVersion=10.7.0.0 | ||
|
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ interface | |
| TCleanCmd = class(TPackage) | ||
| public | ||
| constructor Create; override; | ||
| procedure Generate(ACompiler: TCompiler; const AFlags: TGenerateFlags); override; | ||
| procedure Generate(ACompiler : TCompiler; const AFlags : TGenerateFlags); override; | ||
| end; | ||
|
|
||
| implementation | ||
|
|
@@ -48,61 +48,68 @@ constructor TCleanCmd.Create; | |
|
|
||
| type | ||
| TCleanInfo = record | ||
| ProductName: string; | ||
| Symbol: string; | ||
| FileSuffix: string; | ||
| ProductName : string; | ||
| Symbol : string; | ||
| FileSuffix : string; | ||
| end; | ||
| const | ||
| GCleanCompilers: array[TCompiler] of TCleanInfo = ( | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: 'Delphi 2007'; Symbol: 'D12'; FileSuffix: '2007'), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: 'Delphi 2009'; Symbol: 'D13'; FileSuffix: '2009'), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: 'Delphi 2010'; Symbol: 'D14'; FileSuffix: '2010'), | ||
| (ProductName: 'Delphi XE'; Symbol: 'D15'; FileSuffix: 'XE'), | ||
| (ProductName: 'Delphi XE2'; Symbol: 'D16'; FileSuffix: 'XE2'), | ||
| (ProductName: 'Delphi XE3'; Symbol: 'D17'; FileSuffix: 'XE3'), | ||
| (ProductName: 'Delphi XE4'; Symbol: 'D18'; FileSuffix: 'XE4'), | ||
| (ProductName: 'Delphi XE5'; Symbol: 'D19'; FileSuffix: 'XE5'), | ||
| (ProductName: 'Delphi XE6'; Symbol: 'D20'; FileSuffix: 'XE6'), | ||
| (ProductName: 'Delphi XE7'; Symbol: 'D21'; FileSuffix: 'XE7'), | ||
| (ProductName: 'Delphi XE8'; Symbol: 'D22'; FileSuffix: 'XE8'), | ||
| (ProductName: 'Delphi 10.0 Seattle'; Symbol: 'D23'; FileSuffix: 'Seattle'), | ||
| (ProductName: 'Delphi 10.1 Berlin'; Symbol: 'D24'; FileSuffix: 'Berlin'), | ||
| (ProductName: 'Delphi 10.2 Tokyo'; Symbol: 'D25'; FileSuffix: 'Tokyo'), | ||
| (ProductName: 'Delphi 10.3 Rio'; Symbol: 'D26'; FileSuffix: 'Rio'), | ||
| (ProductName: 'Delphi 10.4 Sydney'; Symbol: 'D27'; FileSuffix: 'Sydney'), | ||
| (ProductName: 'Delphi 11 Alexandria'; Symbol: 'D28'; FileSuffix: 'Alexandria'), | ||
| (ProductName: 'Delphi 12 Athens'; Symbol: 'D29'; FileSuffix: 'Athens'), | ||
| (ProductName: 'Delphi 13 Florence'; Symbol: 'D37'; FileSuffix: 'Florence'), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: ''), | ||
| (ProductName: ''; Symbol: ''; FileSuffix: '') | ||
| ); | ||
|
|
||
| procedure TCleanCmd.Generate(ACompiler: TCompiler; const AFlags: TGenerateFlags); | ||
| GCleanCompilers : array[TCompiler] of TCleanInfo = ( | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : 'Delphi 2007'; Symbol : 'D12'; FileSuffix : '2007'), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : 'Delphi 2009'; Symbol : 'D13'; FileSuffix : '2009'), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : 'Delphi 2010'; Symbol : 'D14'; FileSuffix : '2010'), | ||
| (ProductName : 'Delphi XE'; Symbol : 'D15'; FileSuffix : 'XE'), | ||
| (ProductName : 'Delphi XE2'; Symbol : 'D16'; FileSuffix : 'XE2'), | ||
| (ProductName : 'Delphi XE3'; Symbol : 'D17'; FileSuffix : 'XE3'), | ||
| (ProductName : 'Delphi XE4'; Symbol : 'D18'; FileSuffix : 'XE4'), | ||
| (ProductName : 'Delphi XE5'; Symbol : 'D19'; FileSuffix : 'XE5'), | ||
| (ProductName : 'Delphi XE6'; Symbol : 'D20'; FileSuffix : 'XE6'), | ||
| (ProductName : 'Delphi XE7'; Symbol : 'D21'; FileSuffix : 'XE7'), | ||
| (ProductName : 'Delphi XE8'; Symbol : 'D22'; FileSuffix : 'XE8'), | ||
| (ProductName : 'Delphi 10.0 Seattle'; Symbol : 'D23'; FileSuffix : 'Seattle'), | ||
| (ProductName : 'Delphi 10.1 Berlin'; Symbol : 'D24'; FileSuffix : 'Berlin'), | ||
| (ProductName : 'Delphi 10.2 Tokyo'; Symbol : 'D25'; FileSuffix : 'Tokyo'), | ||
| (ProductName : 'Delphi 10.3 Rio'; Symbol : 'D26'; FileSuffix : 'Rio'), | ||
| (ProductName : 'Delphi 10.4 Sydney'; Symbol : 'D27'; FileSuffix : 'Sydney'), | ||
| (ProductName : 'Delphi 11 Alexandria'; Symbol : 'D28'; FileSuffix : 'Alexandria'), | ||
| (ProductName : 'Delphi 12 Athens'; Symbol : 'D29'; FileSuffix : 'Athens'), | ||
| (ProductName : 'Delphi 13 Florence'; Symbol : 'D37'; FileSuffix : 'Florence'), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : ''), | ||
| (ProductName : ''; Symbol : ''; FileSuffix : '') | ||
| ); | ||
|
|
||
| procedure TCleanCmd.Generate(ACompiler : TCompiler; const AFlags : TGenerateFlags); | ||
| begin | ||
| //We don't call many of the inherited Protected methods because | ||
| //those are for Packages while I'm making a unit. | ||
| //inherited; | ||
|
|
||
| if (GCleanCompilers[ACompiler].ProductName = '') or | ||
| (GCleanCompilers[ACompiler].Symbol = '') then Exit; | ||
| (GCleanCompilers[ACompiler].Symbol = '') then | ||
| Exit; | ||
|
|
||
| FName := 'Clean_' + GCleanCompilers[ACompiler].FileSuffix; | ||
| FExt := '.cmd'; | ||
| // Clean scripts live in each version's Packages\<version> folder; the shared | ||
| // Computil.exe and Clean_IDE.cmd live one level up at the Packages\ root. | ||
| if GPackageFolder[ACompiler] <> '' then | ||
| begin | ||
| FOutputSubDir := 'Packages\' + GPackageFolder[ACompiler]; | ||
| end; | ||
|
|
||
| FCompiler := ACompiler; | ||
| FCode.Clear; | ||
|
|
@@ -111,9 +118,11 @@ procedure TCleanCmd.Generate(ACompiler: TCompiler; const AFlags: TGenerateFlags) | |
| Code('@echo off'); | ||
| Code('set DelphiProd=' + GCleanCompilers[ACompiler].ProductName); | ||
| Code(''); | ||
| Code('cd /d "%~dp0"'); | ||
| Code(''); | ||
| Code('if exist SetEnv.bat del SetEnv.bat'); | ||
| Code('if not exist computil.exe goto NoComputil'); | ||
| Code('computil Setup' + GCleanCompilers[ACompiler].Symbol); | ||
| Code('if not exist "%~dp0..\Computil.exe" goto NoComputil'); | ||
|
vincentparrett marked this conversation as resolved.
Outdated
|
||
| Code('"%~dp0..\Computil.exe" Setup' + GCleanCompilers[ACompiler].Symbol); | ||
| Code('if defined ND' + GCleanCompilers[ACompiler].Symbol + ' goto RSVARS'); | ||
| Code('if not exist SetEnv.bat goto NoNDD'); | ||
| Code(''); | ||
|
|
@@ -126,11 +135,11 @@ procedure TCleanCmd.Generate(ACompiler: TCompiler; const AFlags: TGenerateFlags) | |
| Code(''); | ||
| Code('set logfn=Clean' + GCleanCompilers[ACompiler].Symbol + '.log'); | ||
| Code(''); | ||
| Code('call Clean_IDE.cmd'); | ||
| Code('call "%~dp0..\Clean_IDE.cmd"'); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will remove |
||
| Code('goto END'); | ||
| Code(''); | ||
| Code(':NoCompUtil'); | ||
| Code('echo Computil.exe not found--run this batch script from the "Lib" folder of the Indy repository, recently pulled from GitHub.'); | ||
| Code('echo Computil.exe not found--run this batch script from its version folder under Packages.'); | ||
| Code('goto END'); | ||
| Code(''); | ||
| Code(':NoNDD'); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.