-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(pam): add NTLM auth support for MSSQL #6544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
saifsmailbox98
wants to merge
6
commits into
main
from
saif/pam-226-add-ntlm-auth-support-for-mssql-in-pam
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f4b90e3
feat(pam): add NTLM authentication support for MSSQL
saifsmailbox98 a73afc6
docs(pam): document NTLM auth method for MSSQL accounts
saifsmailbox98 8655008
fix: remove unnecessary type assertions in sql-resource-factory
saifsmailbox98 a7b1810
fix(pam): backwards compat for old MSSQL accounts + strict session sc…
saifsmailbox98 f18e1c0
chore: shorten schema comments
saifsmailbox98 8395a31
Merge remote-tracking branch 'origin/main' into saif/pam-226-add-ntlm…
saifsmailbox98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
backend/src/ee/services/pam-resource/mssql/mssql-resource-enums.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export enum MsSqlAuthMethod { | ||
| SqlLogin = "sql-login", | ||
| Ntlm = "ntlm" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,34 @@ | ||
| import { PamResourceType } from "../enums"; | ||
| import { TBaseSqlConnectionDetails, TBaseSqlCredentials } from "./shared/sql-resource"; | ||
| import { TBaseSqlConnectionDetails } from "./shared/sql-resource"; | ||
| import { TBasePamAccount } from "./base-account"; | ||
| import { TBasePamResource } from "./base-resource"; | ||
|
|
||
| export enum MsSqlAuthMethod { | ||
| SqlLogin = "sql-login", | ||
| Ntlm = "ntlm" | ||
| } | ||
|
|
||
| export type TMsSQLSqlLoginCredentials = { | ||
| authMethod: MsSqlAuthMethod.SqlLogin; | ||
| username: string; | ||
| password: string; | ||
| }; | ||
|
|
||
| export type TMsSQLNtlmCredentials = { | ||
| authMethod: MsSqlAuthMethod.Ntlm; | ||
| username: string; | ||
| password: string; | ||
| domain: string; | ||
| }; | ||
|
|
||
| export type TMsSQLCredentials = TMsSQLSqlLoginCredentials | TMsSQLNtlmCredentials; | ||
|
|
||
| // Resources | ||
| export type TMsSQLResource = TBasePamResource & { resourceType: PamResourceType.MsSQL } & { | ||
| connectionDetails: TBaseSqlConnectionDetails; | ||
| }; | ||
|
|
||
| // Accounts | ||
| export type TMsSQLAccount = TBasePamAccount & { | ||
| credentials: TBaseSqlCredentials; | ||
| credentials: TMsSQLCredentials; | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.