-
Notifications
You must be signed in to change notification settings - Fork 19
feat: Add ktlint to project #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tevincent
wants to merge
23
commits into
main
Choose a base branch
from
ktlint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1bb7579
feat: Add ktlint to project
tevincent 615343e
chore: Update command ran on CI for ktlint
tevincent 46f83a1
chore: Apply ktlint plugin to all projects
tevincent bbae745
chore: Add new rules to disable
tevincent e1980db
feat: Add ktlint to project
tevincent ccb462b
chore: Update command ran on CI for ktlint
tevincent f9cbe1b
chore: Apply ktlint plugin to all projects
tevincent 6c950d5
chore: Add new rules to disable
tevincent f595b69
feat: Add ktlint to project
tevincent d3b99fd
chore: Add baseline
tevincent f743ecd
chore: Update libs.versions.toml and build.gradle.kts
tevincent 3c1363b
chore: Update ktlint plugin
tevincent 9ae813f
chore: Update ktlint version
tevincent 007a4de
chore: Use ktlint from Core
tevincent c344269
chore: Change where the baseline fine is located at
tevincent 53918ba
chore: Update Core
tevincent d7c98de
chore: Use ktlint from Core
tevincent 236af85
chore: Update baselines
tevincent cb6649a
chore: Update android.yml to fix the path for ktlint
tevincent 93788e9
chore: Execute ktlint command instead of downloading the binary
tevincent af7b140
chore: Do a submodule recursive for ktlint
tevincent bfc250b
fix: Use Java 17 for ktlint
tevincent 2159fd2
chore: Update core
tevincent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Kotlin Ktlint | ||
| root = true | ||
|
|
||
| [*.{kt,kts}] | ||
|
|
||
| ktlint_code_style = android_studio | ||
|
|
||
| ktlint_standard_no-wildcard-imports = disabled | ||
| ktlint_standard_no-empty-first-line-in-class-body = disabled | ||
| ktlint_standard_no-line-break-before-assignment = disabled | ||
| ktlint_standard_multiline-expression-wrapping = disabled | ||
| ktlint_standard_string-template-indent = disabled | ||
| ktlint_standard_trailing-comma-on-call-site = disabled | ||
| ktlint_standard_trailing-comma-on-declaration-site = disabled | ||
| ktlint_standard_no-empty-first-line-in-method-block = disabled | ||
| ktlint_standard_expression-body-wrapping = disabled | ||
| ktlint_standard_function-signature = disabled | ||
| ktlint_standard_spacing-between-declarations-with-annotations = disabled | ||
|
|
||
| max_line_length = 130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule Core
updated
90 files
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <baseline version="1.0"> | ||
| <file name="build.gradle.kts"> | ||
| <error line="39" column="25" source="standard:string-template" /> | ||
| </file> | ||
| </baseline> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.