feat: Add custom reminder picker dialog - #2991
Open
Elouan1411 wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a custom delay picker to the draft reminder options.
Changes:
- Adds an hours/days reminder picker dialog.
- Connects custom reminders to send options and analytics.
- Localizes unit labels across supported languages.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
app/src/main/res/values/strings.xml |
Adds default unit plurals. |
app/src/main/res/values-sv/strings.xml |
Adds Swedish unit plurals. |
app/src/main/res/values-pt/strings.xml |
Adds Portuguese unit plurals. |
app/src/main/res/values-pl/strings.xml |
Adds Polish unit plurals. |
app/src/main/res/values-nl/strings.xml |
Adds Dutch unit plurals. |
app/src/main/res/values-nb/strings.xml |
Adds Norwegian unit plurals. |
app/src/main/res/values-it/strings.xml |
Adds Italian unit plurals. |
app/src/main/res/values-fr/strings.xml |
Adds French unit plurals. |
app/src/main/res/values-fi/strings.xml |
Adds Finnish unit plurals. |
app/src/main/res/values-es/strings.xml |
Adds Spanish unit plurals. |
app/src/main/res/values-el/strings.xml |
Adds Greek unit plurals. |
app/src/main/res/values-de/strings.xml |
Adds German unit plurals. |
app/src/main/res/values-da/strings.xml |
Adds Danish unit plurals. |
app/src/main/res/layout/dialog_custom_reminder_picker.xml |
Defines the picker layout. |
app/src/main/java/com/infomaniak/mail/ui/newMessage/sendOptions/DraftSendOptionsFragment.kt |
Integrates custom reminder selection. |
app/src/main/java/com/infomaniak/mail/ui/alertDialogs/CustomReminderPickerDialog.kt |
Implements picker behavior. |
app/src/main/java/com/infomaniak/mail/MatomoMail.kt |
Adds custom-reminder analytics. |
Elouan1411
force-pushed
the
custom-reminder
branch
from
July 23, 2026 08:49
f71220d to
bc681a3
Compare
This was referenced Jul 23, 2026
Elouan1411
force-pushed
the
custom-reminder
branch
2 times, most recently
from
July 27, 2026 08:12
2509de2 to
db6b74c
Compare
Elouan1411
force-pushed
the
custom-reminder
branch
2 times, most recently
from
July 28, 2026 09:25
ccba3c3 to
14486b3
Compare
Elouan1411
force-pushed
the
custom-reminder
branch
from
July 28, 2026 14:06
14486b3 to
9b19675
Compare
FabianDevel
requested changes
Jul 28, 2026
Comment on lines
+46
to
+53
| <TextView | ||
| android:id="@+id/errorMessage" | ||
| style="@style/Body.Error" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:visibility="gone" | ||
| tools:text="The reminder must be at least 1 hour in the future" | ||
| tools:visibility="visible" /> |
Contributor
There was a problem hiding this comment.
YOu can remove this it's unused
Comment on lines
+18
to
+32
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:gravity="center_horizontal" | ||
| android:orientation="vertical" | ||
| android:paddingHorizontal="@dimen/marginStandard" | ||
| android:paddingVertical="@dimen/marginStandardSmall"> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:gravity="center" | ||
| android:orientation="horizontal"> | ||
|
|
Contributor
There was a problem hiding this comment.
Remove one of these 2 layout
Comment on lines
+353
to
+354
| binding.customDelayReminder.setSubtitle(requireContext().formatDelayText(delayMinutes)) | ||
| binding.customDelayReminder.setCheckMark(displayCheckMark = true) |
Contributor
There was a problem hiding this comment.
Suggested change
| binding.customDelayReminder.setSubtitle(requireContext().formatDelayText(delayMinutes)) | |
| binding.customDelayReminder.setCheckMark(displayCheckMark = true) | |
| binding.customDelayReminder.apply { | |
| setSubtitle(requireContext().formatDelayText(delayMinutes)) | |
| customDelayReminder.setCheckMark(displayCheckMark = true) | |
| } |
Comment on lines
+107
to
+108
| val selectedUnitIndex = binding.unitPicker.value | ||
| val selectedUnit = timeUnits[selectedUnitIndex] |
Contributor
There was a problem hiding this comment.
Suggested change
| val selectedUnitIndex = binding.unitPicker.value | |
| val selectedUnit = timeUnits[selectedUnitIndex] | |
| val selectedUnit = timeUnits[binding.unitPicker.value] |
Comment on lines
+83
to
+84
| val selectedUnit = timeUnits[newUnitIndex] | ||
| numberPicker.maxValue = selectedUnit.maxValue |
Contributor
There was a problem hiding this comment.
Suggested change
| val selectedUnit = timeUnits[newUnitIndex] | |
| numberPicker.maxValue = selectedUnit.maxValue | |
| numberPicker.maxValue = timeUnits[newUnitIndex].maxValue |
Elouan1411
force-pushed
the
custom-reminder
branch
2 times, most recently
from
July 29, 2026 14:16
d40a997 to
96d0739
Compare
Elouan1411
force-pushed
the
custom-reminder
branch
2 times, most recently
from
July 30, 2026 09:30
83c700c to
1abc6f1
Compare
Elouan1411
force-pushed
the
custom-reminder
branch
from
July 30, 2026 13:14
1abc6f1 to
18a9599
Compare
Elouan1411
force-pushed
the
custom-reminder
branch
from
July 31, 2026 08:16
18a9599 to
e59c8ac
Compare
Elouan1411
force-pushed
the
custom-reminder
branch
from
July 31, 2026 11:44
e59c8ac to
efc6efe
Compare
Elouan1411
force-pushed
the
custom-reminder
branch
from
July 31, 2026 12:32
efc6efe to
3827bf2
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.