feat: Add visibility reminder dialog by Elouan1411 · Pull Request #2992 · Infomaniak/android-kMail

Elouan1411 · 2026-07-22T13:49:20Z

No description provided.

Copilot

Pull request overview

Adds a localized reminder-visibility dialog to the message send-options flow.

Changes:

Adds “Me only” translations across all supported locales.
Introduces the radio-selection dialog and layout.
Stores and displays the selected visibility in the send-options state.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`app/src/main/res/values/strings.xml`	Adds English label.
`app/src/main/res/values-sv/strings.xml`	Adds Swedish label.
`app/src/main/res/values-pt/strings.xml`	Adds Portuguese label.
`app/src/main/res/values-pl/strings.xml`	Adds Polish label.
`app/src/main/res/values-nl/strings.xml`	Adds Dutch label.
`app/src/main/res/values-nb/strings.xml`	Adds Norwegian label.
`app/src/main/res/values-it/strings.xml`	Adds Italian label.
`app/src/main/res/values-fr/strings.xml`	Adds French label.
`app/src/main/res/values-fi/strings.xml`	Adds Finnish label.
`app/src/main/res/values-es/strings.xml`	Adds Spanish label.
`app/src/main/res/values-el/strings.xml`	Adds Greek label.
`app/src/main/res/values-de/strings.xml`	Adds German label.
`app/src/main/res/values-da/strings.xml`	Adds Danish label.
`app/src/main/res/layout/dialog_select_visibility_reminder.xml`	Defines the visibility choices.
`DraftSendOptionsFragment.kt`	Integrates selection and state handling.
`NewMessageViewModel.kt`	Holds the selected visibility.
`SelectVisibilityReminderDialog.kt`	Implements the selection dialog.

tevincent · 2026-07-28T12:20:14Z

+    private fun initDialog() = with(binding) {
+        MaterialAlertDialogBuilder(activityContext)
+            .setTitle(R.string.reminderVisibilityTitle)
+            .setView(root)


Since you're only using binding for root, you don't need your with.

tevincent · 2026-07-28T12:34:02Z

+  ~ You should have received a copy of the GNU General Public License
+  ~ along with this program.  If not, see <http://www.gnu.org/licenses/>.
+  -->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"


I think you could use a LinearLayout. You could use the SettingRadioGroupView as the root view.

tevincent · 2026-07-28T12:36:04Z


    val scheduleConfig: MutableLiveData<ScheduleConfig> = MutableLiveData(ScheduleConfig.None)
    val reminderConfig: MutableLiveData<ReminderConfig> = MutableLiveData(ReminderConfig.None)
+    val shouldRemindRecipient: MutableLiveData<Boolean> = MutableLiveData(true)


Why is this a LiveData ?

I changed it to a flow

tevincent · 2026-07-28T12:45:48Z

        setReminderOptionsVisible(isVisible = false)
        setScheduleOptionsVisible(isVisible = false)

+        pendingShouldRemindRecipient = newMessageViewModel.shouldRemindRecipient.value ?: true


Any reasons to use another value instead of newMessageViewModel.shouldRemindRecipient?

It was used to work with the save button, but we removed that behavior

FabianDevel · 2026-07-29T12:04:40Z

+    private fun setupListeners() = with(binding) {
+        reminderVisibilityGroup.onItemCheckedListener { id, _, _ ->
+            this@SelectVisibilityReminderDialog.isRecipientsAndMeSelected = (id == R.id.selectionReminderRecipientsAndMe)
+        }
+
+        positiveButton.setOnClickListener {
+            onVisibilitySelected?.invoke(this@SelectVisibilityReminderDialog.isRecipientsAndMeSelected)
+            alertDialog.dismiss()
+        }
+
+        negativeButton.setOnClickListener { alertDialog.cancel() }
+    }


Suggested change

private fun setupListeners() = with(binding) {

reminderVisibilityGroup.onItemCheckedListener { id, _, _ ->

this@SelectVisibilityReminderDialog.isRecipientsAndMeSelected = (id == R.id.selectionReminderRecipientsAndMe)

}

positiveButton.setOnClickListener {

onVisibilitySelected?.invoke(this@SelectVisibilityReminderDialog.isRecipientsAndMeSelected)

alertDialog.dismiss()

}

negativeButton.setOnClickListener { alertDialog.cancel() }

}

private fun setupListeners() {

binding.reminderVisibilityGroup.onItemCheckedListener { id, _, _ ->

isRecipientsAndMeSelected = id == R.id.selectionReminderRecipientsAndMe

}

positiveButton.setOnClickListener {

onVisibilitySelected?.invoke(isRecipientsAndMeSelected)

alertDialog.dismiss()

}

negativeButton.setOnClickListener { alertDialog.cancel() }

}

FabianDevel · 2026-07-29T12:25:56Z

+    private var shouldRemindRecipient: Boolean
+        get() = newMessageViewModel.shouldRemindRecipient.value ?: true
+        set(value) {
+            newMessageViewModel.shouldRemindRecipient.value = value
+        }


As the other, it should be a stateFlow in the viewModel that's observed and update the UI accordingly

sonarqubecloud · 2026-07-31T12:38:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Elouan1411 changed the title ~~Select visibility~~ feat: Add visibility reminder dialog and integrate with scheduling options Jul 22, 2026

Elouan1411 changed the title ~~feat: Add visibility reminder dialog and integrate with scheduling options~~ feat: Add visibility reminder dialog Jul 22, 2026

github-actions Bot assigned Elouan1411 Jul 22, 2026

Elouan1411 requested a review from Copilot July 22, 2026 14:18

Copilot started reviewing on behalf of Elouan1411 July 22, 2026 14:19 View session

Copilot AI reviewed Jul 22, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/ui/newMessage/sendOptions/DraftSendOptionsFragment.kt Outdated

Elouan1411 force-pushed the select-visibility branch from 6394ac6 to a010bde Compare July 22, 2026 14:25

Elouan1411 force-pushed the select-visibility branch from a010bde to 8a7e7bf Compare July 23, 2026 08:56

Elouan1411 force-pushed the select-visibility branch from 8a7e7bf to 45c7e45 Compare July 23, 2026 13:01

Elouan1411 force-pushed the select-visibility branch from 45c7e45 to c65b503 Compare July 27, 2026 08:12

Elouan1411 force-pushed the select-visibility branch 2 times, most recently from 287df90 to 099759a Compare July 28, 2026 09:25

tevincent requested changes Jul 28, 2026

View reviewed changes

Elouan1411 force-pushed the select-visibility branch from 099759a to 3a39a05 Compare July 28, 2026 14:06

Elouan1411 force-pushed the select-visibility branch from 3a39a05 to fde3c80 Compare July 28, 2026 15:49

FabianDevel requested changes Jul 29, 2026

View reviewed changes

Elouan1411 force-pushed the select-visibility branch from fde3c80 to 204d4eb Compare July 29, 2026 14:16

Elouan1411 force-pushed the select-visibility branch from 204d4eb to 5418d90 Compare July 30, 2026 08:42

Elouan1411 force-pushed the select-visibility branch from 5418d90 to b5180c2 Compare July 30, 2026 09:31

Elouan1411 force-pushed the select-visibility branch from b5180c2 to f64fc7e Compare July 30, 2026 13:15

Elouan1411 force-pushed the select-visibility branch 2 times, most recently from 1942087 to c2842b3 Compare July 31, 2026 11:44

Elouan1411 added 4 commits July 31, 2026 13:46

feat: Add string

9d5a0fd

feat: Add visibility reminder dialog

61fdd26

refactor: Clean code

f1d6b31

refactor: Observe shouldReminderRecipient

d934dd8

Elouan1411 force-pushed the select-visibility branch from c2842b3 to d934dd8 Compare July 31, 2026 12:33

Navigation Menu

Uh oh!

feat: Add visibility reminder dialog - #2992

feat: Add visibility reminder dialog#2992
Elouan1411 wants to merge 4 commits into
custom-reminderfrom
select-visibility

Elouan1411 commented Jul 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

tevincent Jul 28, 2026

Uh oh!

tevincent Jul 28, 2026

Uh oh!

tevincent Jul 28, 2026

Uh oh!

Elouan1411 Jul 30, 2026

Uh oh!

tevincent Jul 28, 2026

Uh oh!

Elouan1411 Jul 30, 2026

Uh oh!

FabianDevel Jul 29, 2026

Uh oh!

FabianDevel Jul 29, 2026

Uh oh!

sonarqubecloud Bot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Elouan1411 commented Jul 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 31, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants