fix: Fix path traversal on attachment - #3013
Open
FabianDevel wants to merge 6 commits into
Open
Conversation
Sanitize the attachment name to remove possible path traversal
FabianDevel
added
enhancement
There was a problem hiding this comment.
Pull request overview
Hardens attachment handling against path traversal and unsafe filenames.
Changes:
- Adds filename sanitization and path-containment utilities with tests.
- Applies safe names across storage, downloads, uploads, headers, and UI.
- Propagates nullable cache paths to callers.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
FileNameUtils.kt |
Adds sanitization and containment helpers. |
FileNameUtilsTest.kt |
Tests filename and path security. |
LocalStorageUtils.kt |
Secures cache and upload paths. |
AttachableExtensions.kt |
Adds safe attachment names and cache paths. |
AttachmentExt.kt |
Handles nullable cache files and safe labels. |
NewMessageViewModel.kt |
Sanitizes imported attachment names. |
MainViewModel.kt |
Sanitizes download filenames. |
MessageWebViewClient.kt |
Handles rejected cache paths. |
AttachmentDetailsView.kt |
Displays sanitized names. |
AttachmentAdapter.kt |
Uses sanitized accessibility labels. |
ApiRepository.kt |
Sanitizes attachment filename headers. |
FabianDevel
force-pushed
the
fix-path-traversal-on-attachment
branch
from
August 4, 2026 12:34
fddd5b8 to
60cb8c8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.