chore: Apply split - #1
Merged
Merged
Conversation
# Conflicts: # app/build.gradle.kts # gradle/libs.versions.toml wip wip # Conflicts: # multiplatform-lib/src/commonMain/kotlin/AuthenticatorFacade.kt # multiplatform-lib/src/commonMain/kotlin/internal/AuthenticatorFacadeImpl.kt # multiplatform-lib/src/commonMain/kotlin/internal/managers/MigrationManager.kt wip # Conflicts: # multiplatform-lib/src/commonMain/kotlin/internal/AuthenticatorFacadeImpl.kt # Conflicts: # app/build.gradle.kts
# Conflicts: # multiplatform-lib/src/commonMain/kotlin/AuthenticatorFacade.kt # multiplatform-lib/src/commonMain/kotlin/DummyAuthenticatorFacade.kt # multiplatform-lib/src/commonMain/kotlin/internal/AuthenticatorFacadeImpl.kt
Fixed by setting up AuthConfiguration for refresh to work and re-fetching the token from the DB on retry, so we can get the refreshed one.
…on the native side and on KMP
If the completeMigration API call failed, the user would end up locked for the given account. It turns out the completeMigration API call is not mandatory to fully migrate the app, and it might be replaced by the detection of passkey use, so we're now doing a fire and forget, until we can completely remove it.
Before, it was hidden by our app bar on Android, because we had incorrect padding.
It was caused by the accounts flow not yet in sync with the db contents.
Now, instead of using the accountEntities Flow, we use the accounts one, which has been updated to reflect that we're about to start migration. This commit also adds some clarifying comments to explain the desired behavior.
This will allow it to be used across multiple "targets" in the iOS project.
sirambd
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.