Skip to content

fix: Fix concurrent writes clashing #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LouisCAD merged 1 commit into from
Aug 4, 2026
+6 −2
Merged

fix: Fix concurrent writes clashing #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions AuthenticatorCore/src/appleMain/kotlin/internal/otp/TotpGenerator.apple.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import kotlinx.cinterop.BetaInteropApi
import kotlinx.cinterop.ExperimentalForeignApi
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.IO
import kotlinx.coroutines.sync.Mutex
import kotlinx.coroutines.sync.withLock
import kotlinx.coroutines.withContext
import kotlinx.serialization.json.Json
import kotlinx.serialization.json.int
Expand All @@ -31,6 +33,8 @@ import kotlinx.serialization.json.jsonPrimitive
import platform.Foundation.NSData
import platform.Foundation.NSUserDefaults

private val writeMutex = Mutex()

@OptIn(BetaInteropApi::class, ExperimentalForeignApi::class)
internal actual suspend fun getLegacyAccounts(): List<LegacyUser> = withContext(Dispatchers.IO) {
val userDefaults = NSUserDefaults.standardUserDefaults
Expand All @@ -51,10 +55,10 @@ internal actual suspend fun getLegacyAccounts(): List<LegacyUser> = withContext(
}

@OptIn(ExperimentalForeignApi::class)
internal actual suspend fun deleteLegacyAccount(userId: String) {
internal actual suspend fun deleteLegacyAccount(userId: String) = writeMutex.withLock {
withContext(Dispatchers.IO) {
val userDefaults = NSUserDefaults.standardUserDefaults
val usersData = userDefaults.objectForKey("ALL_USERS") as? MutableList<*> ?: return@withContext false
val usersData = userDefaults.objectForKey("ALL_USERS") as? MutableList<*> ?: return@withContext

val updatedList = usersData.mapNotNull { item ->
val data = item as? NSData ?: return@mapNotNull item
Expand Down
Loading