Skip to content

S3 Features Overhaul 🚀 #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garronej wants to merge 322 commits into
base: main
Choose a base branch
from

Fix bookmark links not including the ambient profile

cd77c69
Select commit
Loading
Failed to load commit list.
Open

S3 Features Overhaul 🚀 #1057

Fix bookmark links not including the ambient profile
cd77c69
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 8, 2026 in 1m 5s

Quality Gate failed

Failed conditions
2 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 349 in web/src/ui/shared/codex/S3Uploads/S3Upload.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ0kU4tahkAMMveQYRNC&open=AZ0kU4tahkAMMveQYRNC&pullRequest=1057

Check warning on line 57 in web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBarItem/S3BookmarksBarItem.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "S3BookmarkItemProps". 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZz8efx1qIGHSd6lah9j&open=AZz8efx1qIGHSd6lah9j&pullRequest=1057

Check warning on line 342 in web/src/core/usecases/s3ExplorerUiController/thunks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'never' is overridden by other types in this union type. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZyZZ9cV_TisDgi17lEA&open=AZyZZ9cV_TisDgi17lEA&pullRequest=1057

Check warning on line 10 in web/src/core/usecases/s3ExplorerUiController/evt.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'./state' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZyZZ9cM_TisDgi17lD-&open=AZyZZ9cM_TisDgi17lD-&pullRequest=1057

Check warning on line 144 in web/src/core/usecases/s3ExplorerUiController/evt.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.some(…)` over `.find(…)`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZyZZ9cM_TisDgi17lD_&open=AZyZZ9cM_TisDgi17lD_&pullRequest=1057

Check warning on line 129 in web/src/ui/shared/codex/S3ProfileSelect/S3ProfileSelect.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <input type="button">, <input type="image">, <input type="reset">, <input type="submit">, or <button> instead of the "button" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZzTUosE-bigFxr29dXL&open=AZzTUosE-bigFxr29dXL&pullRequest=1057

Check warning on line 98 in web/src/core/usecases/s3ProfilesManagement/decoupledLogic/resolveTemplatedStsRole.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_m9AvKEmeUrlRKr-&open=AZy4_m9AvKEmeUrlRKr-&pullRequest=1057

Check warning on line 195 in web/src/core/usecases/launcher/thunks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "use_pinned_s3_profile" label. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mxAvKEmeUrlRKrb&open=AZy4_mxAvKEmeUrlRKrb&pullRequest=1057

Check warning on line 605 in web/src/ui/shared/codex/S3UriBar/S3UriBar.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mvevKEmeUrlRKrI&open=AZy4_mvevKEmeUrlRKrI&pullRequest=1057

Check warning on line 702 in web/src/core/usecases/launcher/thunks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mxAvKEmeUrlRKrd&open=AZy4_mxAvKEmeUrlRKrd&pullRequest=1057

Check warning on line 92 in web/src/core/usecases/s3ProfilesManagement/decoupledLogic/resolveTemplatedBookmark.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_m8OvKEmeUrlRKry&open=AZy4_m8OvKEmeUrlRKry&pullRequest=1057

Check warning on line 151 in web/src/ui/pages/home/Page.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mj3vKEmeUrlRKqS&open=AZy4_mj3vKEmeUrlRKqS&pullRequest=1057

Check warning on line 335 in web/src/ui/shared/codex/S3Bookmarks/S3BookmarksBarItem/S3BookmarksBarItem.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <input type="button">, <input type="image">, <input type="reset">, <input type="submit">, or <button> instead of the "button" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZz8efx1qIGHSd6lah9p&open=AZz8efx1qIGHSd6lah9p&pullRequest=1057

Check warning on line 600 in web/src/ui/shared/codex/S3UriBar/S3UriBar.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mvevKEmeUrlRKrH&open=AZy4_mvevKEmeUrlRKrH&pullRequest=1057

Check warning on line 1073 in web/src/ui/shared/codex/S3UriBar/S3UriBar.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The attribute aria-expanded is not supported by the role textbox. This role is implicit on the element input. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mvevKEmeUrlRKrP&open=AZy4_mvevKEmeUrlRKrP&pullRequest=1057

Check warning on line 1022 in web/src/ui/shared/codex/S3UriBar/S3UriBar.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ0b0dOBiE7KP8YCPfLA&open=AZ0b0dOBiE7KP8YCPfLA&pullRequest=1057

Check warning on line 317 in web/src/ui/i18n/resources/fi.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Ambiguous spacing before next element code 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mpjvKEmeUrlRKqg&open=AZy4_mpjvKEmeUrlRKqg&pullRequest=1057

Check warning on line 466 in web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ0ISbsCumBrAXp5y46L&open=AZ0ISbsCumBrAXp5y46L&pullRequest=1057

Check warning on line 90 in web/src/core/usecases/s3ProfilesCreationUiController/selectors.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code to remove this label and the need for it. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_myXvKEmeUrlRKri&open=AZy4_myXvKEmeUrlRKri&pullRequest=1057

Check warning on line 773 in web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZ0ISbsCumBrAXp5y46Q&open=AZ0ISbsCumBrAXp5y46Q&pullRequest=1057

Check warning on line 5 in web/src/core/usecases/s3ExplorerUiController/evt.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'tsafe' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_m1ovKEmeUrlRKrn&open=AZy4_m1ovKEmeUrlRKrn&pullRequest=1057

Check warning on line 81 in web/src/core/usecases/s3ProfilesManagement/decoupledLogic/resolveTemplatedStsRole.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_m9AvKEmeUrlRKr6&open=AZy4_m9AvKEmeUrlRKr6&pullRequest=1057

Check warning on line 324 in web/src/ui/i18n/resources/es.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Ambiguous spacing before next element code 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_moVvKEmeUrlRKqb&open=AZy4_moVvKEmeUrlRKqb&pullRequest=1057

Check warning on line 189 in web/src/core/usecases/projectManagement/thunks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This case's code block is the same as the block for the case on line 180. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZy4_mzsvKEmeUrlRKrl&open=AZy4_mzsvKEmeUrlRKrl&pullRequest=1057

Check warning on line 581 in web/src/core/usecases/s3ExplorerUiController/selectors.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Block is redundant. 

See more on https://sonarcloud.io/project/issues?id=InseeFrLab_onyxia&issues=AZznPnQVg_CIIJlE4Gs3&open=AZznPnQVg_CIIJlE4Gs3&pullRequest=1057
View more details on SonarQubeCloud