Skip to content

Implement s3 profile modal (WIP)#1070

Open
garronej wants to merge 14 commits intoexplorer_deep_reworkfrom
s3_profile_modal
Open

Implement s3 profile modal (WIP)#1070
garronej wants to merge 14 commits intoexplorer_deep_reworkfrom
s3_profile_modal

Conversation

@garronej
Copy link
Copy Markdown
Contributor

@garronej garronej commented Apr 11, 2026

image

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 11, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 983ab030-4898-44d5-95a8-a2ad86a24879

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch s3_profile_modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

garronej added 8 commits April 29, 2026 11:04
@garronej
Move S3 profile modal into explorer dialogs
7b98365 
Rename profile modal/dialog naming for consistency
Replace old create/update profile dialog usage with S3ProfileDialog
Remove obsolete create/update profile dialog i18n resources
Rename shared S3 profile UI folder from modal to dialog
Fix custom profile edit availability in profile details
@garronej
Refactor S3ProfileDialog types for active view management
9f420b9
@garronej
Add isEditionOfAnExistingConfig prop to S3ProfileForm for edit mode h…
0801192 
…andling
@garronej
Add comment to clarify isEditionOfAnExistingConfig prop usage in S3Pr…
8346a17 
…ofileForm
@garronej
Workable draft of the profile edit side modal
31452a4
@garronej
Minimal S3ProfileDetail component
dc0c2ee
@garronej
Making sure the tokens are updated when changing profile
be2dd0a
@garronej
Implement read of public/private policy in the core
9278b84
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 30, 2026
View reviewed changes
Comment thread web/src/ui/shared/codex/s3ProfileDialog/S3ProfileDetails/S3ProfileDetails.stories.tsx
expirationTime: Date.now() + 1000 * 60 * 60 * 4,
accessKeyId: "ASIAIOSFODNN7EXAMPLE",
secretAccessKey: "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
sessionToken: "IQoJb3JpZ2luX2VjEOr//////////wEaCXVzLWVhc3QtMSJHMEUCIDbN",
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garronej @github-advanced-security