Skip to content

ENH: Fix buffer ownership and a redundant copy in SimpleITK interop #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjmjohnson merged 1 commit into from
Sep 4, 2026
+9 −7
Merged

ENH: Fix buffer ownership and a redundant copy in SimpleITK interop #6828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions Wrapping/Generators/Python/itk/support/extras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,9 +815,11 @@ def image_from_simpleitk(sitk_image) -> itkt.ImageBase:
Geometry is read in ITK (x, y, z) order, via the order-explicit
``spacing_xyz``/``origin_xyz``/``direction_xyz`` keys when the object
provides them and otherwise via ``GetSpacing()``/``GetOrigin()``/
``GetDirection()``. Pixels are copied through SimpleITK's array API.
Multi-component images become an itk.VectorImage. Entries reported by
``GetMetaDataKeys()`` are copied into the MetaDataDictionary.
``GetDirection()``. Pixels are deep-copied into a buffer the returned
image owns, so it is independent of ``sitk_image`` and safe for
grafting or in-place filters. Multi-component images become an
itk.VectorImage. Entries reported by ``GetMetaDataKeys()`` are copied
into the MetaDataDictionary.

Parameters
----------
Expand All @@ -836,9 +838,9 @@ def image_from_simpleitk(sitk_image) -> itkt.ImageBase:
number_of_components = sitk_image.GetNumberOfComponentsPerPixel()
is_vector = number_of_components != 1

array = sitk.GetArrayFromImage(sitk_image)
array = sitk.GetArrayViewFromImage(sitk_image)

l_image = itk.image_view_from_array(array, is_vector=is_vector)
l_image = itk.image_from_array(array, is_vector=is_vector)

spacing = _spatial_from_order_explicit(sitk_image, "spacing")
if spacing is not None:
Expand Down Expand Up @@ -879,8 +881,8 @@ def simpleitk_from_image(image: itkt.ImageOrImageSource):

image = itk.output(image)

# Updates the image, so the regions compared below are the ones just read.
array = itk.array_from_image(image)
# Updates the image; a view is safe since GetImageFromArray deep-copies.
array = itk.array_view_from_image(image)

buffered_region = image.GetBufferedRegion()
largest_region = image.GetLargestPossibleRegion()
Expand Down
Loading