Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the multiprocessing (mp) engines (Ray + ZMQ) to better synchronize streaming session lifecycle, harden a few race/error cases, and improve observability around Ray startup.
Changes:
- Add session “ready/exist” signaling for streaming RPC paths (plumb an
asyncio.Eventthrough mp-engine streaming calls). - Harden Ray shared actor creation and streaming output gathering against race/error cases.
- Add logging of Ray initialization address.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lmdeploy/pytorch/ray.py | Captures ray.init() context and logs the initialized address. |
| lmdeploy/pytorch/engine/mp_engine/zmq_rpc.py | Extends streaming client API to accept a session event and signal it once streaming begins. |
| lmdeploy/pytorch/engine/mp_engine/zmq_engine.py | Plumbs session event through ZMQ mp-engine streaming path. |
| lmdeploy/pytorch/engine/mp_engine/ray_engine.py | Adds init/error handling around Ray streaming tasks and plumbs session event through Ray mp-engine streaming path. |
| lmdeploy/pytorch/engine/mp_engine/base_worker.py | Avoids KeyError in EngineOutputGather.pop() when no gathered output exists for a stream. |
| lmdeploy/pytorch/engine/mp_engine/base.py | Changes streaming RPC abstract signature and uses a per-session asyncio.Event for lifecycle synchronization. |
| lmdeploy/pytorch/engine/engine_instance.py | Handles Ray actor creation race for shared store and introduces notify_add_msg_func hook in streaming infer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist