Add herald to the development shell - #1400
Merged
Merged
Conversation
Changelog fragments are expected in every PR (see the PR template), but herald was so far only available through `nix run github:input-output-hk/cardano-dev#herald`. Provide it in the devshell the same way cardano-api does, via the cardano-dev flake.
palas
requested review from
a team,
Jimbo4350,
carbolymer,
disassembler,
kevinhammond and
newhoggy
as code owners
July 25, 2026 00:58
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the herald changelog-fragment tool to cardano-cli’s Nix development shell by pulling it from the cardano-dev flake, aligning the devshell experience with cardano-api.
Changes:
- Add
cardano-devas a flake input and includeheraldinnativeBuildInputsfor the devshell. - Update
flake.lockto account for the new flake input and its resolved dependency graph. - Add a changelog fragment documenting the maintenance change.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
flake.nix |
Adds cardano-dev input and wires herald into the devshell nativeBuildInputs. |
flake.lock |
Locks the newly introduced cardano-dev input and related dependency resolutions. |
.changes/20260724_235840_cardano-cli_pablo.lamela_add_herald_to_devshell.yml |
Adds a changelog fragment for the devshell tooling update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| incl.url = "github:divnix/incl"; | ||
| flake-utils.url = "github:hamishmack/flake-utils/hkm/nested-hydraJobs"; | ||
| pre-commit-hooks.url = "github:cachix/git-hooks.nix"; | ||
| cardano-dev.url = "github:input-output-hk/cardano-dev"; |
Contributor
There was a problem hiding this comment.
I suppose this is a good idea. But herald is already cached on cache.iog.io, and I've trimmed down the closure so it should not be that big input-output-hk/cardano-dev#31 . I guess what I'm saying, that's this might be not that beneficial change as it looks at the first glance.
Jimbo4350
approved these changes
Jul 27, 2026
carbolymer
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
cardano-apihasheraldin thenixdeveloper shell, butcardano-clidoesn't. This PR addresses that.How to trust this PR
Only tiny change to flake. The rest are
flake.lockchanges. So if CI builds, and the tool is available in thenixshell, it is a pretty safe change.Checklist
.changes/