Skip to content

Commit an update to the CHaP flake input when the repo is deployed - #1397

Draft
neilmayhew wants to merge 2 commits into
mainfrom
nm/update-CHaP-flake-input-on-deploy
Draft

Commit an update to the CHaP flake input when the repo is deployed#1397
neilmayhew wants to merge 2 commits into
mainfrom
nm/update-CHaP-flake-input-on-deploy

Conversation

@neilmayhew

Copy link
Copy Markdown
Contributor

The lock of the CHaP flake input should be updated whenever the repo branch is updated, which happens in the deploy GitHub workflow step.

This would avoid the need for manual interventions like #1396 to unbreak the Hydra build.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to automatically keep the CHaP flake input lock up to date whenever the repo branch is updated during the deploy workflow, reducing the need for manual flake-lock bump interventions to keep downstream builds (e.g., Hydra) unblocked.

Changes:

  • Adds a new “Update flake input” step to the deploy job that updates CHaP in flake.lock and pushes the result.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/CI.yml Outdated
@neilmayhew
neilmayhew marked this pull request as draft June 29, 2026 22:27
@neilmayhew

Copy link
Copy Markdown
Contributor Author

Unfortunately, the only way to test this is to merge it, and I doubt that it will work as-is. For example, I assume that it's not possible to push directly to main with the current repo settings, but we can't include the commit in the PR before merging because the repo branch hasn't been updated at that point so we don't have the commit hash. We also don't want to generate a corresponding flake-update PR for every other type of PR that's merged.

Ideally, we'd allow direct pushes to main on a selective basis, but I don't know how that could be achieved.

So this PR is more about having a discussion than getting something merged right away.

@neilmayhew
neilmayhew force-pushed the nm/update-CHaP-flake-input-on-deploy branch from 83f3700 to a0343f8 Compare June 29, 2026 22:44
@neilmayhew
neilmayhew requested a review from Copilot June 29, 2026 22:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/CI.yml Outdated
@neilmayhew

neilmayhew commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

We do have a weekly scheduled job to update haskell.nix as well as CHaP, but that's currently broken. It fails to create a PR, with

remote: Permission to IntersectMBO/cardano-haskell-packages.git denied to logan-the-lobster

The problem with automatically generated PRs — even the ones that succeed — is that nobody seems to be looking at them.

@neilmayhew
neilmayhew force-pushed the nm/update-CHaP-flake-input-on-deploy branch from a0343f8 to 53ca85f Compare June 29, 2026 22:55
@neilmayhew
neilmayhew requested a review from Copilot June 29, 2026 22:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/CI.yml
Comment thread .github/workflows/CI.yml Outdated
@neilmayhew
neilmayhew force-pushed the nm/update-CHaP-flake-input-on-deploy branch from 53ca85f to 8b1f51d Compare June 29, 2026 23:10
@neilmayhew
neilmayhew requested a review from Copilot June 29, 2026 23:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/CI.yml
Comment thread .github/workflows/CI.yml Outdated
@neilmayhew
neilmayhew force-pushed the nm/update-CHaP-flake-input-on-deploy branch from 8b1f51d to 15810f7 Compare June 29, 2026 23:27
@neilmayhew
neilmayhew requested a review from Copilot June 29, 2026 23:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants