refactor(logfiles): build ignored error regexes lazily - #3582
Merged
Conversation
The environment-specific ignored error regexes (GitHub Actions, testnet) were appended to the ERRORS_IGNORED module constant at import time. That called get_cluster_type() on import, pinned the cluster type to the import-time environment and mutated a module level constant. Move the environment-specific additions to a function that is called when the log search runs. The cluster type is then determined on first use rather than at import time and ERRORS_IGNORED stays immutable.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors logfiles so environment-specific “ignored error” regexes (GitHub Actions / testnet) are assembled lazily at log-search runtime instead of mutating ERRORS_IGNORED during module import, avoiding import-time cluster type pinning and side effects.
Changes:
- Introduced
_get_ignored_error_regexes()to build the effective ignored-regex list based on the current environment at first use. - Updated cluster log searching to use the lazily-built ignored-regex list.
- Added unit coverage to validate the ignored-regex list across combinations of
GITHUB_ACTIONSand cluster type.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cardano_node_tests/utils/logfiles.py |
Moves env-specific ignored-regex selection into a lazy runtime helper and uses it during log searching. |
framework_tests/test_logfiles.py |
Adds a parametrized unit test ensuring ignored regexes reflect runtime environment rather than import-time state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The environment-specific ignored error regexes (GitHub Actions, testnet) were appended to the ERRORS_IGNORED module constant at import time. That called get_cluster_type() on import, pinned the cluster type to the import-time environment and mutated a module level constant.
Move the environment-specific additions to a function that is called when the log search runs. The cluster type is then determined on first use rather than at import time and ERRORS_IGNORED stays immutable.