test(framework): silence expected gh_issue error logs - #3586
Merged
Conversation
The gh_issue unit tests deliberately drive error paths, and the resulting ERROR records were printed by pytest live logging. Raise the gh_issue logger level to CRITICAL via a quiet_logger fixture in the tests that expect errors, keeping the test output clean.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR keeps framework_tests output clean by silencing expected error-level logging emitted from cardano_node_tests.utils.gh_issue when unit tests intentionally exercise error paths.
Changes:
- Added a
quiet_loggerpytest fixture that raises thegh_issuemodule logger threshold toCRITICALviacaplog.set_level. - Applied the fixture (via
@pytest.mark.usefixtures) to the specific tests that intentionally triggerERROR/exceptionlogs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gh_issue unit tests deliberately drive error paths, and the resulting ERROR records were printed by pytest live logging. Raise the gh_issue logger level to CRITICAL via a quiet_logger fixture in the tests that expect errors, keeping the test output clean.